Issue 8384036: Delete GlobarError and Protector only after the error was removed from global list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8384036: Delete GlobarError and Protector only after the error was removed from global list. (Closed)

Created:
9 years, 1 month ago by whywhat

Modified:
9 years, 1 month ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Delete GlobarError and Protector only after the error was removed from global list. BUG=None TEST=Make Protector bubble appear, click on Go to settings, then on Wrench menu button. Chrome should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108114

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
M	chrome/browser/protector/protector.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/protector/protector.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/protector/settings_change_global_error.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/protector/settings_change_global_error_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM with discussed fix to closing sequence.

Expand Messages | Collapse Messages