Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: chrome/browser/protector/settings_change_global_error.cc

Issue 8384036: Delete GlobarError and Protector only after the error was removed from global list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/protector/settings_change_global_error.cc
===================================================================
--- chrome/browser/protector/settings_change_global_error.cc (revision 108092)
+++ chrome/browser/protector/settings_change_global_error.cc (working copy)
@@ -153,17 +153,17 @@
}
void SettingsChangeGlobalError::BubbleViewAcceptButtonPressed() {
+ closed_by_button_ = true;
DCHECK(delegate_);
VLOG(1) << "Apply changes";
delegate_->OnApplyChanges();
- closed_by_button_ = true;
}
void SettingsChangeGlobalError::BubbleViewCancelButtonPressed() {
+ closed_by_button_ = true;
DCHECK(delegate_);
VLOG(1) << "Discard changes";
delegate_->OnDiscardChanges();
- closed_by_button_ = true;
}
void SettingsChangeGlobalError::RemoveFromProfile() {
@@ -172,6 +172,7 @@
GlobalErrorServiceFactory::GetForProfile(profile_)->RemoveGlobalError(this);
if (!closed_by_button_)
delegate_->OnDecisionTimeout();
+ delegate_->OnRemovedFromProfile();
}
void SettingsChangeGlobalError::BubbleViewDidClose() {
« no previous file with comments | « chrome/browser/protector/protector.cc ('k') | chrome/browser/protector/settings_change_global_error_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698