Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10035)

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

Issue 8384023: Remove some unused code in PhishingDOMFeatureExtractor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
index 65e3ec0c51fc5efd7efee0ada33c1b9254cc0bea..15779a83542f2eb6c4fd3ac559aad44984716b0f 100644
--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc
@@ -170,11 +170,7 @@ void PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout() {
} else {
// We just moved to a new frame, so update our frame state
// and advance to the first element.
- if (!ResetFrameData()) {
- // Nothing in this frame, move on to the next one.
- DLOG(WARNING) << "No content in frame, skipping";
- continue;
- }
+ ResetFrameData();
cur_node = cur_frame_data_->elements.firstItem();
}
@@ -381,7 +377,7 @@ void PhishingDOMFeatureExtractor::Clear() {
cur_document_.reset();
}
-bool PhishingDOMFeatureExtractor::ResetFrameData() {
+void PhishingDOMFeatureExtractor::ResetFrameData() {
DCHECK(!cur_document_.isNull());
DCHECK(!cur_frame_data_.get());
@@ -390,7 +386,6 @@ bool PhishingDOMFeatureExtractor::ResetFrameData() {
cur_frame_data_->domain =
net::RegistryControlledDomainService::GetDomainAndRegistry(
cur_document_.url());
- return true;
}
WebKit::WebDocument PhishingDOMFeatureExtractor::GetNextDocument() {
« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698