Remove some unused code in PhishingDOMFeatureExtractor.

chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/safe_browsing/phishing_dom_feature_extractor.h"
 
 #include "base/compiler_specific.h"
 #include "base/hash_tables.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 152 matching lines @@
       cur_node = cur_frame_data_->elements.nextItem();
       // When we resume the traversal, the first call to nextItem() potentially
       // has to walk through the document again from the beginning, if it was
       // modified between our chunks of work.  Log how long this takes, so we
       // can tell if it's too slow.
       UMA_HISTOGRAM_TIMES("SBClientPhishing.DOMFeatureResumeTime",
                           clock_->Now() - current_chunk_start_time);
     } else {
       // We just moved to a new frame, so update our frame state
       // and advance to the first element.
-      if (!ResetFrameData()) {
-        // Nothing in this frame, move on to the next one.
-        DLOG(WARNING) << "No content in frame, skipping";
-        continue;
-      }
+      ResetFrameData();
       cur_node = cur_frame_data_->elements.firstItem();
     }
 
     for (; !cur_node.isNull();
          cur_node = cur_frame_data_->elements.nextItem()) {
       if (!cur_node.isElementNode()) {
         continue;
       }
       WebKit::WebElement element = cur_node.to<WebKit::WebElement>();
       if (element.hasTagName("a")) {
@@ skipping 186 matching lines @@
   Clear();
 }
 
 void PhishingDOMFeatureExtractor::Clear() {
   features_ = NULL;
   done_callback_.reset(NULL);
   cur_frame_data_.reset(NULL);
   cur_document_.reset();
 }
 
-bool PhishingDOMFeatureExtractor::ResetFrameData() {
+void PhishingDOMFeatureExtractor::ResetFrameData() {
   DCHECK(!cur_document_.isNull());
   DCHECK(!cur_frame_data_.get());
 
   cur_frame_data_.reset(new FrameData());
   cur_frame_data_->elements = cur_document_.all();
   cur_frame_data_->domain =
       net::RegistryControlledDomainService::GetDomainAndRegistry(
           cur_document_.url());
-  return true;
 }
 
 WebKit::WebDocument PhishingDOMFeatureExtractor::GetNextDocument() {
   DCHECK(!cur_document_.isNull());
   WebKit::WebFrame* frame = cur_document_.frame();
   // Advance to the next frame that contains a document, with no wrapping.
   if (frame) {
     while ((frame = frame->traverseNext(false))) {
       if (!frame->document().isNull()) {
         return frame->document();
@@ skipping 89 matching lines @@
   // Record number of script tags (discretized for numerical stability.)
   if (page_feature_state_->num_script_tags > 1) {
     features_->AddBooleanFeature(features::kPageNumScriptTagsGTOne);
     if (page_feature_state_->num_script_tags > 6) {
       features_->AddBooleanFeature(features::kPageNumScriptTagsGTSix);
     }
   }
 }
 
 }  // namespace safe_browsing