Make some ErrorCode-s compile-time errors and some just type warnings

tests/stub-generator/stub-generator.status

Index: tests/stub-generator/stub-generator.status
diff --git a/tests/stub-generator/stub-generator.status b/tests/stub-generator/stub-generator.status
index 784cc4ca20b677ea1208c1758e6d130fee01c35f..cfa8a9ad22e4e785ac80bf14c9d0d5700e069938 100644
--- a/tests/stub-generator/stub-generator.status
+++ b/tests/stub-generator/stub-generator.status
@@ -7,6 +7,8 @@ prefix stub-generator
 [ $component == vm ]
 
 [ $component == dartc ]
+MintMakerPromiseWithStubsTest : Skip    # Bug 5365165
+MintMakerFullyIsolatedTest : Skip       # Bug 5365165

[Ben Laurie (Google), 2011/11/02 18:08:34]

The problem here is not bug 5365165 (which is fixed, anyway), but that you have
broken the stub generator by making unresolved types errors: these have to be
warnings when shouldWarnOnNoSuchType() is true.

[zundel, 2011/11/02 18:16:59]

Hi Ben,

I know it is frustrating to see a test that has been working for so long go red.

What's happened is we've gotten rid of the 'warnOnNoSuchType' feature in dartc
intentionally, as there is no such advertised feature in Dart.  We've also
synced up with the spec.  After syncing up, there are some cases that have
changed. Before it was always an error.  Now we've gone through and made it a
warning in cases where it is supposed to be a warning, and an error in those
cases where it is defined to be a compile time error, clarified with Gilad's
help.  

In the case of what are now compile time error cases, AFAIK, there is no way to
make proper functioning code that is Dart spec compliant - if you find a counter
example in the spec, let us know or file a bug.

 
 [ $arch == x64 ]
 *: Skip