tests/stub-generator/stub-generator.status - Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/stub-generator/stub-generator.status

Issue 8384012: Make some ErrorCode-s compile-time errors and some just type warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Changes for comments Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 prefix stub-generator	5 prefix stub-generator

6	6

7 [ $component == vm ]	7 [ $component == vm ]

8	8

9 [ $component == dartc ]	9 [ $component == dartc ]

	10 MintMakerPromiseWithStubsTest : Skip # Bug 5365165

	11 MintMakerFullyIsolatedTest : Skip # Bug 5365165
	Ben Laurie (Google) 2011/11/02 18:08:34 The problem here is not bug 5365165 (which is fixe The problem here is not bug 5365165 (which is fixed, anyway), but that you have broken the stub generator by making unresolved types errors: these have to be warnings when shouldWarnOnNoSuchType() is true. zundel 2011/11/02 18:16:59 Hi Ben, I know it is frustrating to see a test th Show quoted text On 2011/11/02 18:08:34, Ben Laurie (Google) wrote: > The problem here is not bug 5365165 (which is fixed, anyway), but that you have > broken the stub generator by making unresolved types errors: these have to be > warnings when shouldWarnOnNoSuchType() is true. Hi Ben, I know it is frustrating to see a test that has been working for so long go red. What's happened is we've gotten rid of the 'warnOnNoSuchType' feature in dartc intentionally, as there is no such advertised feature in Dart. We've also synced up with the spec. After syncing up, there are some cases that have changed. Before it was always an error. Now we've gone through and made it a warning in cases where it is supposed to be a warning, and an error in those cases where it is defined to be a compile time error, clarified with Gilad's help. In the case of what are now compile time error cases, AFAIK, there is no way to make proper functioning code that is Dart spec compliant - if you find a counter example in the spec, let us know or file a bug.
10	12

11 [ $arch == x64 ]	13 [ $arch == x64 ]

12 *: Skip	14 *: Skip

13	15

14 [ $arch == simarm ]	16 [ $arch == simarm ]

15 *: Skip	17 *: Skip

16	18

17 [ $arch == arm ]	19 [ $arch == arm ]

18 *: Skip	20 *: Skip

19	21

20 [ $component == dartium ]	22 [ $component == dartium ]

21 *: Skip	23 *: Skip

22	24

23 [ $component == chromium ]	25 [ $component == chromium ]

24 *: Skip	26 *: Skip

OLD	NEW

« no previous file with comments | « tests/language/src/WrongNumberTypeArgumentsTest.dart ('k') | no next file » | no next file with comments »