Adding parameter to GetStatusLabels to indicate if links are acceptable.

chrome/browser/sync/sync_ui_util.h

Index: chrome/browser/sync/sync_ui_util.h
diff --git a/chrome/browser/sync/sync_ui_util.h b/chrome/browser/sync/sync_ui_util.h
index 2ded4eba00f322238b4960a76ee570891506438b..181005c72824d11862b9d6372ee159dc7b614563 100644
--- a/chrome/browser/sync/sync_ui_util.h
+++ b/chrome/browser/sync/sync_ui_util.h
@@ -37,10 +37,11 @@ enum MessageType {
 
 // Create status and link labels for the current status labels and link text
 // by querying |service|.
-// |status_label| may contain an HTML-formatted link.
+// If |html_links| is true, |status_label| may contain an HTML-formatted link.
 MessageType GetStatusLabels(ProfileSyncService* service,
                             string16* status_label,
-                            string16* link_label);
+                            string16* link_label,
+                            bool html_links);

[akalin, 2011/10/28 19:10:22]

Chromium style is to avoid booleans in favor of enums, and I think it'll help
readability in this case.

How about:

enum StatusLabelStyle { PLAIN_TEXT, WITH_HTML };

Also, input args go before mixed/output args, so:

MessageType GetStatusLabels(StatusLabelStyle ...,
                            ProfileSyncService* ...,
                            string16* ...);

[jimblackler, 2011/11/01 16:15:30]

Done.

 
 // Same as above but for use specifically on the New Tab Page.
 // |status_label| may contain an HTML-formatted link.