Adding parameter to GetStatusLabels to indicate if links are acceptable.

chrome/browser/sync/sync_ui_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_
 #define CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_
 #pragma once
 
 #include <string>
 
@@ skipping 19 matching lines @@
   SYNC_ERROR,  // A sync error (such as invalid credentials) has occurred.
   SYNC_PROMO,  // A situation has occurred which should be brought to the user's
                // attention, but not as an error.
 };
 
 // TODO(akalin): audit the use of ProfileSyncService* service below,
 // and use const ProfileSyncService& service where possible.
 
 // Create status and link labels for the current status labels and link text
 // by querying |service|.
-// |status_label| may contain an HTML-formatted link.
+// If |html_links| is true, |status_label| may contain an HTML-formatted link.
 MessageType GetStatusLabels(ProfileSyncService* service,
                             string16* status_label,
-                            string16* link_label);
+                            string16* link_label,
+                            bool html_links);

[akalin, 2011/10/28 19:10:22]

Chromium style is to avoid booleans in favor of enums, and I think it'll help
readability in this case.

How about:

enum StatusLabelStyle { PLAIN_TEXT, WITH_HTML };

Also, input args go before mixed/output args, so:

MessageType GetStatusLabels(StatusLabelStyle ...,
                            ProfileSyncService* ...,
                            string16* ...);

[jimblackler, 2011/11/01 16:15:30]

Done.

 
 // Same as above but for use specifically on the New Tab Page.
 // |status_label| may contain an HTML-formatted link.
 MessageType GetStatusLabelsForNewTabPage(ProfileSyncService* service,
                                          string16* status_label,
                                          string16* link_label);
 
 // Gets various labels for the sync global error based on the sync error state.
 // |menu_item_label|, |bubble_message|, and |bubble_accept_label| must not be
 // NULL.
@@ skipping 24 matching lines @@
 
 void AddIntSyncDetail(base::ListValue* details,
                       const std::string& stat_name,
                       int64 stat_value);
 
 void AddStringSyncDetails(ListValue* details, const std::string& stat_name,
                           const std::string& stat_value);
 
 }  // namespace sync_ui_util
 #endif  // CHROME_BROWSER_SYNC_SYNC_UI_UTIL_H_