Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 8383006: Adds function to invert a transform to ui::Transform (Closed)

Created:
9 years, 2 months ago by pkotwicz
Modified:
9 years, 2 months ago
Reviewers:
Ian Vollick, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Adds function to invert a transform to ui::Transform Required for http://codereview.chromium.org/8368013/ BUG= None TEST= None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106992

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes as requested #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ui/gfx/transform.h View 1 1 chunk +3 lines, -0 lines 1 comment Download
M ui/gfx/transform.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
9 years, 2 months ago (2011-10-24 15:59:38 UTC) #1
sky
http://codereview.chromium.org/8383006/diff/1/ui/gfx/transform.cc File ui/gfx/transform.cc (right): http://codereview.chromium.org/8383006/diff/1/ui/gfx/transform.cc#newcode106 ui/gfx/transform.cc:106: return transform->matrix_.invert(&transform->matrix_); Am I missing something. This isn't using ...
9 years, 2 months ago (2011-10-24 16:45:05 UTC) #2
pkotwicz
http://codereview.chromium.org/8383006/diff/1/ui/gfx/transform.cc File ui/gfx/transform.cc (right): http://codereview.chromium.org/8383006/diff/1/ui/gfx/transform.cc#newcode106 ui/gfx/transform.cc:106: return transform->matrix_.invert(&transform->matrix_); Thanks for pointing this out. Fixed
9 years, 2 months ago (2011-10-24 19:17:13 UTC) #3
sky
9 years, 2 months ago (2011-10-24 21:08:59 UTC) #4
LGTM

http://codereview.chromium.org/8383006/diff/5001/ui/gfx/transform.h
File ui/gfx/transform.h (right):

http://codereview.chromium.org/8383006/diff/5001/ui/gfx/transform.h#newcode72
ui/gfx/transform.h:72: // Inverts the transform which is passed in. Returns true
if successful.
This description is a bit misleading. I think you mean:
Inverts this transform storing the result in |transform|. Returns true if this
matrix can be inverted.

Powered by Google App Engine
This is Rietveld 408576698