Consider the signature algorithms of incomplete chains on Windows

Consider the signature algorithms of incomplete chains on Windows

R=wtc@chromium.org
BUG=101123
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108082

[Ryan Sleevi, 2011-10-25 01:20:54]

wtc: Noticed while testing, split into it's own CL.

For an incomplete chain of:
  EE -> Intermediate
which is untrusted by the system, we consistently skip checking if
|intermediate| was signed with md[2,4,5].

This changes it so that chains of
  EE -> Intermediate
report on both certs, while chains of
  EE -> Intermediate -> Root
only report on EE -> Intermediate.

[wtc, 2011-10-25 01:36:46]

Patch Set 1 LGTM.  Thanks for writing this CL.  Please fix
the bug below before committing this.

http://codereview.chromium.org/8382026/diff/1/net/base/x509_certificate_win.cc
File net/base/x509_certificate_win.cc (right):

http://codereview.chromium.org/8382026/diff/1/net/base/x509_certificate_win.c...
net/base/x509_certificate_win.cc:315: // available intermediate. If a root CA
certificate is present, do not

Move "(i = num_elements - 1)" after "the last available intermediate" because it
applies to both possibilities,
not just the root CA certificate.

Or you can simply remove "(i = num_elements - 1)".  This
may be a good idea because we may change num_elements
below,.

http://codereview.chromium.org/8382026/diff/1/net/base/x509_certificate_win.c...
net/base/x509_certificate_win.cc:352:
verified_chain.push_back(element[num_elements - 1]->pCertContext);

BUG: the array index should be num_elements because we
decremented num_elements above in this case (lines 318-322).

[commit-bot: I haz the power, 2011-10-25 23:56:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8382026/4002

[commit-bot: I haz the power, 2011-10-26 00:59:16]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 107247, job name
was 8382026-4002 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2011-11-01 07:55:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/8382026/8001

[commit-bot: I haz the power, 2011-11-01 09:10:11]

Change committed as 108082