Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: net/base/x509_certificate_unittest.cc

Issue 8382026: Consider the signature algorithms of incomplete chains on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Enable tests on Windows Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/base/x509_certificate_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/pickle.h" 8 #include "base/pickle.h"
9 #include "base/sha1.h" 9 #include "base/sha1.h"
10 #include "base/string_number_conversions.h" 10 #include "base/string_number_conversions.h"
(...skipping 1623 matching lines...) Expand 10 before | Expand all | Expand 10 after
1634 1634
1635 // Incomplete chains should still report the status of the intermediate. 1635 // Incomplete chains should still report the status of the intermediate.
1636 const WeakDigestTestData kVerifyIncompleteIntermediateTestData[] = { 1636 const WeakDigestTestData kVerifyIncompleteIntermediateTestData[] = {
1637 { NULL, "weak_digest_md5_intermediate.pem", "weak_digest_sha1_ee.pem", 1637 { NULL, "weak_digest_md5_intermediate.pem", "weak_digest_sha1_ee.pem",
1638 true, false, false, true, false }, 1638 true, false, false, true, false },
1639 { NULL, "weak_digest_md4_intermediate.pem", "weak_digest_sha1_ee.pem", 1639 { NULL, "weak_digest_md4_intermediate.pem", "weak_digest_sha1_ee.pem",
1640 false, true, false, false, false }, 1640 false, true, false, false, false },
1641 { NULL, "weak_digest_md2_intermediate.pem", "weak_digest_sha1_ee.pem", 1641 { NULL, "weak_digest_md2_intermediate.pem", "weak_digest_sha1_ee.pem",
1642 false, false, true, false, true }, 1642 false, false, true, false, true },
1643 }; 1643 };
1644 // Disabled on Windows - http://crbug.com/101123. The Windows implementation
1645 // does not report the status of the last intermediate for incomplete chains.
1646 // Disabled on NSS - libpkix does not return constructed chains on error, 1644 // Disabled on NSS - libpkix does not return constructed chains on error,
1647 // preventing us from detecting/inspecting the verified chain. 1645 // preventing us from detecting/inspecting the verified chain.
1648 #if defined(OS_WIN) || defined(USE_NSS) 1646 #if defined(USE_NSS)
1649 #define MAYBE_VerifyIncompleteIntermediate \ 1647 #define MAYBE_VerifyIncompleteIntermediate \
1650 DISABLED_VerifyIncompleteIntermediate 1648 DISABLED_VerifyIncompleteIntermediate
1651 #else 1649 #else
1652 #define MAYBE_VerifyIncompleteIntermediate VerifyIncompleteIntermediate 1650 #define MAYBE_VerifyIncompleteIntermediate VerifyIncompleteIntermediate
1653 #endif 1651 #endif
1654 WRAPPED_INSTANTIATE_TEST_CASE_P( 1652 WRAPPED_INSTANTIATE_TEST_CASE_P(
1655 MAYBE_VerifyIncompleteIntermediate, 1653 MAYBE_VerifyIncompleteIntermediate,
1656 X509CertificateWeakDigestTest, 1654 X509CertificateWeakDigestTest,
1657 testing::ValuesIn(kVerifyIncompleteIntermediateTestData)); 1655 testing::ValuesIn(kVerifyIncompleteIntermediateTestData));
1658 1656
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
1695 #define MAYBE_VerifyMixed VerifyMixed 1693 #define MAYBE_VerifyMixed VerifyMixed
1696 #endif 1694 #endif
1697 WRAPPED_INSTANTIATE_TEST_CASE_P( 1695 WRAPPED_INSTANTIATE_TEST_CASE_P(
1698 MAYBE_VerifyMixed, 1696 MAYBE_VerifyMixed,
1699 X509CertificateWeakDigestTest, 1697 X509CertificateWeakDigestTest,
1700 testing::ValuesIn(kVerifyMixedTestData)); 1698 testing::ValuesIn(kVerifyMixedTestData));
1701 1699
1702 #endif // defined(USE_NSS) || defined(OS_WIN) 1700 #endif // defined(USE_NSS) || defined(OS_WIN)
1703 1701
1704 } // namespace net 1702 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/base/x509_certificate_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698