net/base/x509_certificate_unittest.cc - Issue 8381017: net: retain leading zero bytes in X.509 serial numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_unittest.cc

Issue 8381017: net: retain leading zero bytes in X.509 serial numbers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_unittest.cc

diff --git a/net/base/x509_certificate_unittest.cc b/net/base/x509_certificate_unittest.cc

index 9ba1124023fe5ceb2a8107b05c3d167ba8a32479..4887929178592666a644e985cce737a1c8dd2f70 100644

--- a/net/base/x509_certificate_unittest.cc

+++ b/net/base/x509_certificate_unittest.cc

@@ -426,7 +426,7 @@ TEST(X509CertificateTest, SerialNumbers) {

reinterpret_cast<const char*>(paypal_null_der),

sizeof(paypal_null_der)));

- static const uint8 paypal_null_serial[2] = {0xf0, 0x9b};

+ static const uint8 paypal_null_serial[3] = {0x00, 0xf0, 0x9b};

wtc 2011/10/25 21:14:44 I was going to suggest that we add a unit test for

ASSERT_EQ(sizeof(paypal_null_serial),

paypal_null_cert->serial_number().size());

EXPECT_TRUE(memcmp(paypal_null_cert->serial_number().data(),