net/base/x509_certificate_openssl.cc - Issue 8381017: net: retain leading zero bytes in X.509 serial numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/x509_certificate_openssl.cc

Issue 8381017: net: retain leading zero bytes in X.509 serial numbers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/x509_certificate_openssl.cc

diff --git a/net/base/x509_certificate_openssl.cc b/net/base/x509_certificate_openssl.cc

index 80e2517a0be870ea269589ab259128772f3246a9..f39b348b08485094bf370fc7e9a088e2c23d4b99 100644

--- a/net/base/x509_certificate_openssl.cc

+++ b/net/base/x509_certificate_openssl.cc

@@ -332,9 +332,6 @@ void X509Certificate::Initialize() {

serial_number_ = std::string(

reinterpret_cast<char*>(num->data),

num->length);

- // Remove leading zeros.

- while (serial_number_.size() > 1 && serial_number_[0] == 0)

- serial_number_ = serial_number_.substr(1, serial_number_.size() - 1);

}

ParsePrincipal(cert_handle_, X509_get_subject_name(cert_handle_), &subject_);