Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: chrome/browser/sync/profile_sync_factory.h

Issue 8375047: Separate the syncing of extension settings and app settings into separate data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_factory.h
diff --git a/chrome/browser/sync/profile_sync_factory.h b/chrome/browser/sync/profile_sync_factory.h
index d956d3cc94a5090baacd75002690b949f30c74f1..8e60f084630b4ca2481d91d5b9ec0de852ffafca 100644
--- a/chrome/browser/sync/profile_sync_factory.h
+++ b/chrome/browser/sync/profile_sync_factory.h
@@ -15,7 +15,6 @@
#include "chrome/browser/sync/glue/model_associator.h"
#include "chrome/browser/sync/unrecoverable_error_handler.h"
-class ExtensionSettingsBackend;
class PasswordStore;
class PersonalDataManager;
class ProfileSyncService;
@@ -115,10 +114,12 @@ class ProfileSyncFactory {
browser_sync::UnrecoverableErrorHandler* error_handler) = 0;
// Instantiates both a model associator and change processor for the
- // extension setting data type. The pointers in the return struct are
+ // extension or app setting data type. The pointers in the return struct are
// owned by the caller.
- virtual SyncComponents CreateExtensionSettingSyncComponents(
- ExtensionSettingsBackend* extension_settings_backend_,
+ virtual SyncComponents CreateExtensionOrAppSettingSyncComponents(
+ // Either EXTENSION_SETTINGS or APP_SETTINGS.
+ syncable::ModelType type,
+ SyncableService* settings_service,
ProfileSyncService* profile_sync_service,
browser_sync::UnrecoverableErrorHandler* error_handler) = 0;

Powered by Google App Engine
This is Rietveld 408576698