chrome/browser/sync/profile_sync_factory_impl.h - Issue 8375047: Separate the syncing of extension settings and app settings into separate data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_factory_impl.h

Issue 8375047: Separate the syncing of extension settings and app settings into separate data (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_factory.h ('k') | chrome/browser/sync/profile_sync_factory_impl.cc » ('j') | chrome/browser/sync/syncable/model_type.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_factory_impl.h

diff --git a/chrome/browser/sync/profile_sync_factory_impl.h b/chrome/browser/sync/profile_sync_factory_impl.h

index f7e7494c93bd55ea6de670a876134a387bdfff17..8d962f1f36cd7ed53944002a63f80f561dbcde0d 100644

--- a/chrome/browser/sync/profile_sync_factory_impl.h

+++ b/chrome/browser/sync/profile_sync_factory_impl.h

@@ -12,7 +12,6 @@

#include "chrome/browser/sync/profile_sync_factory.h"

class CommandLine;

-class ExtensionSettingsBackend;

class Profile;

class ProfileSyncFactoryImpl : public ProfileSyncFactory {

@@ -53,8 +52,10 @@ class ProfileSyncFactoryImpl : public ProfileSyncFactory {

ProfileSyncService* profile_sync_service,

browser_sync::UnrecoverableErrorHandler* error_handler);

- virtual SyncComponents CreateExtensionSettingSyncComponents(

- ExtensionSettingsBackend* extension_settings_backend,

+ virtual SyncComponents CreateExtensionOrAppSettingSyncComponents(

+ // Either EXTENSION_SETTING or APP_SETTING.

+ syncable::ModelType type,

+ SyncableService* settings_service,

ProfileSyncService* profile_sync_service,

browser_sync::UnrecoverableErrorHandler* error_handler);