Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Issue 8375044: Revert 107031 - Breaks those on NewGit due to http://crbug.com/101448 (Closed)

Created:
9 years, 2 months ago by Ryan Sleevi
Modified:
9 years, 2 months ago
Reviewers:
Ronghua
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 107031 - Breaks those on NewGit due to http://crbug.com/101448 Add the target to build peerconnection native in libjingle.gyp. TEST=Unittests Review URL: http://codereview.chromium.org/8374014 TBR=ronghuawu@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M third_party/libjingle/libjingle.gyp View 11 chunks +10 lines, -40 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
9 years, 2 months ago (2011-10-25 05:10:47 UTC) #1
Ryan Sleevi
Apologies for reverting, but I couldn't find you on IRC. As mentioned in the revert ...
9 years, 2 months ago (2011-10-25 05:12:35 UTC) #2
Ronghua
Thanks Ryan. Looks like I might have to do that. On Mon, Oct 24, 2011 ...
9 years, 2 months ago (2011-10-25 06:17:30 UTC) #3
Ryan Sleevi
9 years, 2 months ago (2011-10-25 06:28:26 UTC) #4
On 2011/10/25 06:17:30, Ronghua wrote:
> Thanks Ryan. Looks like I might have to do that.

If it's not a big checkout, that's probably fine (eg: a viable long-term
solution). I didn't look too deeply into the size, I assumed you sliced the
checkout for a reason, which newgit doesn't like.

Powered by Google App Engine
This is Rietveld 408576698