Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 8374014: Add the target to build peerconnection native in libjingle.gyp (Closed)

Created:
9 years, 2 months ago by Ronghua
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Niklas Enbom, grunell (dont use)
Visibility:
Public.

Description

Add the target to build peerconnection native in libjingle.gyp. TEST=Unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107031 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107201

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -10 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 11 chunks +40 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ronghua
Add the json related files as jsoncpp has landed in chromium.
9 years, 2 months ago (2011-10-24 18:33:51 UTC) #1
Sergey Ulanov
http://codereview.chromium.org/8374014/diff/2001/third_party/libjingle/libjingle.gyp File third_party/libjingle/libjingle.gyp (right): http://codereview.chromium.org/8374014/diff/2001/third_party/libjingle/libjingle.gyp#newcode369 third_party/libjingle/libjingle.gyp:369: '../jsoncpp/jsoncpp.gyp:jsoncpp', Please change this and other dependency definitions in ...
9 years, 2 months ago (2011-10-24 20:00:46 UTC) #2
Ronghua
Thanks. http://codereview.chromium.org/8374014/diff/2001/third_party/libjingle/libjingle.gyp File third_party/libjingle/libjingle.gyp (right): http://codereview.chromium.org/8374014/diff/2001/third_party/libjingle/libjingle.gyp#newcode369 third_party/libjingle/libjingle.gyp:369: '../jsoncpp/jsoncpp.gyp:jsoncpp', On 2011/10/24 20:00:46, sergeyu wrote: > Please ...
9 years, 2 months ago (2011-10-24 21:05:07 UTC) #3
Sergey Ulanov
lgtm
9 years, 2 months ago (2011-10-24 21:41:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@google.com/8374014/4002
9 years, 2 months ago (2011-10-24 21:45:47 UTC) #5
commit-bot: I haz the power
Try job failure for 8374014-4002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
9 years, 2 months ago (2011-10-24 22:42:16 UTC) #6
Ronghua
Updated to fix the build error on Mac.
9 years, 2 months ago (2011-10-24 23:21:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@google.com/8374014/4003
9 years, 2 months ago (2011-10-24 23:26:28 UTC) #8
commit-bot: I haz the power
Change committed as 107031
9 years, 2 months ago (2011-10-25 00:50:14 UTC) #9
Ronghua
On 2011/10/25 00:50:14, I haz the power (commit-bot) wrote: > Change committed as 107031 This ...
9 years, 2 months ago (2011-10-25 19:48:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ronghuawu@google.com/8374014/12001
9 years, 2 months ago (2011-10-25 20:05:32 UTC) #11
commit-bot: I haz the power
9 years, 1 month ago (2011-10-25 21:11:47 UTC) #12
Change committed as 107201

Powered by Google App Engine
This is Rietveld 408576698