chrome/browser/extensions/extension_tabs_apitest.cc - Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Default to creating incognito windows when incognito param is not specified. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_tabs_apitest.cc

diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc

index 672f6a75bcd2ca4e110eff9513da7eaaed213304..68f465ce35c81b80c7d23e080ebf2b61eb432732 100644

--- a/chrome/browser/extensions/extension_tabs_apitest.cc

+++ b/chrome/browser/extensions/extension_tabs_apitest.cc

@@ -222,3 +222,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) {

ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

<< message_;

}

+// Adding a new test? Awesome. But API tests are the old hotness. The

+// new hotness is extension_test_utils. See extension_tabs_test.cc for

+// an example. We are trying to phase out many uses of API tests as

+// they tend to be flakey.

pastarmovj 2011/10/27 09:14:31 Isn't it flaky instead of flakey? :)

rustema 2011/10/29 06:43:21 Yeah, that may be confusing. Changed.

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module.cc » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')