chrome/browser/extensions/extension_tabs_apitest.cc - Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 8373027: Prevent incognito windows from opening when incognito mode is disabled. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Default to creating incognito windows when incognito param is not specified. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

7 #include "chrome/browser/prefs/incognito_mode_prefs.h"	7 #include "chrome/browser/prefs/incognito_mode_prefs.h"

8 #include "chrome/browser/prefs/pref_service.h"	8 #include "chrome/browser/prefs/pref_service.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

(...skipping 204 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
215 }	215 }

216	216

217 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedPopup) {	217 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedPopup) {

218 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))	218 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))

219 << message_;	219 << message_;

220 }	220 }

221 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) {	221 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) {

222 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))	222 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

223 << message_;	223 << message_;

224 }	224 }

	225

	226 // Adding a new test? Awesome. But API tests are the old hotness. The

	227 // new hotness is extension_test_utils. See extension_tabs_test.cc for

	228 // an example. We are trying to phase out many uses of API tests as

	229 // they tend to be flakey.
	pastarmovj 2011/10/27 09:14:31 Isn't it flaky instead of flakey? :) Isn't it flaky instead of flakey? :) rustema 2011/10/29 06:43:21 Yeah, that may be confusing. Changed. Show quoted text On 2011/10/27 09:14:31, pastarmovj wrote: > Isn't it flaky instead of flakey? :) Yeah, that may be confusing. Changed.
OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_tabs_module.cc » ('j') | chrome/browser/extensions/extension_tabs_module.cc » ('J')