Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U...

chrome/browser/autofill/autofill_download.cc

Index: chrome/browser/autofill/autofill_download.cc
===================================================================
--- chrome/browser/autofill/autofill_download.cc	(revision 106795)
+++ chrome/browser/autofill/autofill_download.cc	(working copy)
@@ -18,6 +18,7 @@
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
+#include "content/common/net/url_fetcher.h"
 #include "googleurl/src/gurl.h"
 #include "net/http/http_response_headers.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlparser.h"
@@ -317,7 +318,8 @@
   } else {
     VLOG(1) << "AutofillDownloadManager: " << type_of_request
             << " request has succeeded";
-    const std::string& response_body = source->GetResponseStringRef();
+    std::string response_body;
+    CHECK(source->GetResponseAsString(&response_body));

[Ilya Sherman, 2011/10/23 00:20:12]

nit: Do we really need a CHECK() here?  Per Brett's recent email, I'd expect a
DCHECK to be preferable.

[jam, 2011/10/23 01:29:18]

brett's email was about logging. do CHECKs also add that much code? I doubt it.

also, I put a CHECK because that's how the code used to do it before my change
in the GetResponseStringRef implementation

     if (it->second.request_type == AutofillDownloadManager::REQUEST_QUERY) {
       CacheQueryRequest(it->second.form_signatures, response_body);
       if (observer_)