Convert URLFetcher::Delegates to use an interface in content/public/common. Also remove the old U...

chrome/browser/autofill/autofill_download.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_download.h"
 
 #include <algorithm>
 #include <ostream>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/autofill_xml_parser.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
+#include "content/common/net/url_fetcher.h"
 #include "googleurl/src/gurl.h"
 #include "net/http/http_response_headers.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlparser.h"
 
 namespace {
 const char kAutofillQueryServerRequestUrl[] =
     "https://toolbarqueries.google.com/tbproxy/af/query";
 const char kAutofillUploadServerRequestUrl[] =
     "https://toolbarqueries.google.com/tbproxy/af/upload";
 const char kAutofillQueryServerNameStartInHeader[] = "GFE/";
@@ skipping 279 matching lines @@
                  << " request has failed with response "
                  << source->response_code();
     if (observer_) {
       observer_->OnServerRequestError(it->second.form_signatures[0],
                                       it->second.request_type,
                                       source->response_code());
     }
   } else {
     VLOG(1) << "AutofillDownloadManager: " << type_of_request
             << " request has succeeded";
-    const std::string& response_body = source->GetResponseStringRef();
+    std::string response_body;
+    CHECK(source->GetResponseAsString(&response_body));

[Ilya Sherman, 2011/10/23 00:20:12]

nit: Do we really need a CHECK() here?  Per Brett's recent email, I'd expect a
DCHECK to be preferable.

[jam, 2011/10/23 01:29:18]

brett's email was about logging. do CHECKs also add that much code? I doubt it.

also, I put a CHECK because that's how the code used to do it before my change
in the GetResponseStringRef implementation

     if (it->second.request_type == AutofillDownloadManager::REQUEST_QUERY) {
       CacheQueryRequest(it->second.form_signatures, response_body);
       if (observer_)
         observer_->OnLoadedServerPredictions(response_body);
     } else {
       double new_positive_upload_rate = 0;
       double new_negative_upload_rate = 0;
       AutofillUploadXmlParser parse_handler(&new_positive_upload_rate,
                                             &new_negative_upload_rate);
       buzz::XmlParser parser(&parse_handler);
       parser.Parse(response_body.data(), response_body.length(), true);
       if (parse_handler.succeeded()) {
         SetPositiveUploadRate(new_positive_upload_rate);
         SetNegativeUploadRate(new_negative_upload_rate);
       }
 
       if (observer_)
         observer_->OnUploadedPossibleFieldTypes();
     }
   }
   delete it->first;
   url_fetchers_.erase(it);
 }