Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 8373018: Internalize JSON chunk merging to trace_event.h API (retry). (Closed)

Created:
9 years, 2 months ago by jbates
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Internalize JSON chunk merging to trace_event.h API (retry). Original review: http://codereview.chromium.org/8355024/ BUG=100291 TEST=base_unittests, content_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106924

Patch Set 1 #

Patch Set 2 : base_export #

Patch Set 3 : more BASE_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -57 lines) Patch
M base/debug/trace_event.h View 1 2 2 chunks +47 lines, -1 line 0 comments Download
M base/debug/trace_event.cc View 3 chunks +43 lines, -2 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 10 chunks +40 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M content/browser/trace_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/trace_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/trace_subscriber_stdio.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/trace_subscriber_stdio.cc View 4 chunks +15 lines, -21 lines 0 comments Download
M content/browser/trace_subscriber_stdio_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/child_trace_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/child_trace_message_filter.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 16:22:28 UTC) #1
No reviewers yet.

Powered by Google App Engine
This is Rietveld 408576698