Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: content/browser/trace_controller.h

Issue 8373018: Internalize JSON chunk merging to trace_event.h API (retry). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more BASE_EXPORT Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/tracing_ui.cc ('k') | content/browser/trace_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/trace_controller.h
diff --git a/content/browser/trace_controller.h b/content/browser/trace_controller.h
index 3d748208221f2427114b446d382564adeb4e20ce..7ac1676f3a4eb1be4daceaa895ccf72661ab3126 100644
--- a/content/browser/trace_controller.h
+++ b/content/browser/trace_controller.h
@@ -23,8 +23,9 @@ class CONTENT_EXPORT TraceSubscriber {
// Called once after TraceController::EndTracingAsync.
virtual void OnEndTracingComplete() = 0;
// Called 0 or more times between TraceController::BeginTracing and
- // OnEndTracingComplete.
- virtual void OnTraceDataCollected(const std::string& json_events) = 0;
+ // OnEndTracingComplete. Use base::debug::TraceResultBuffer to convert one or
+ // more trace fragments to JSON.
+ virtual void OnTraceDataCollected(const std::string& trace_fragment) = 0;
// Called once after TraceController::GetKnownCategoriesAsync.
virtual void OnKnownCategoriesCollected(
const std::set<std::string>& known_categories) {}
@@ -134,7 +135,7 @@ class CONTENT_EXPORT TraceController {
void OnEndTracingAck(const std::vector<std::string>& known_categories);
void OnTraceDataCollected(
const scoped_refptr<base::debug::TraceLog::RefCountedString>&
- json_events_str_ptr);
+ events_str_ptr);
void OnTraceBufferFull();
void OnTraceBufferPercentFullReply(float percent_full);
« no previous file with comments | « chrome/browser/ui/webui/tracing_ui.cc ('k') | content/browser/trace_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698