Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 8372015: [Linux] Load plugins out-of-process. (Closed)

Created:
9 years, 2 months ago by Robert Sesek
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Linux] Load plugins out-of-process. This also fixes a bug in PluginLoaderPosix where if the last N plugins in the canonical list crash, the callbacks are never run. BUG=17863 TEST=On Linux, plugins work as before. Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106962 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=106977 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108286

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M content/browser/plugin_loader_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 6 chunks +12 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 2 chunks +37 lines, -0 lines 0 comments Download
M content/browser/plugin_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
9 years, 2 months ago (2011-10-24 14:46:47 UTC) #1
Bernhard Bauer
http://codereview.chromium.org/8372015/diff/1/content/browser/plugin_loader_posix.cc File content/browser/plugin_loader_posix.cc (right): http://codereview.chromium.org/8372015/diff/1/content/browser/plugin_loader_posix.cc#newcode50 content/browser/plugin_loader_posix.cc:50: LoadPluginsInternal(); You could have the check for an empty ...
9 years, 2 months ago (2011-10-24 14:57:08 UTC) #2
Robert Sesek
http://codereview.chromium.org/8372015/diff/1/content/browser/plugin_loader_posix.cc File content/browser/plugin_loader_posix.cc (right): http://codereview.chromium.org/8372015/diff/1/content/browser/plugin_loader_posix.cc#newcode50 content/browser/plugin_loader_posix.cc:50: LoadPluginsInternal(); On 2011/10/24 14:57:08, Bernhard Bauer wrote: > You ...
9 years, 2 months ago (2011-10-24 16:44:40 UTC) #3
Bernhard Bauer
LGTM.
9 years, 2 months ago (2011-10-24 16:58:04 UTC) #4
jam
lgtm
9 years, 2 months ago (2011-10-24 17:47:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/8372015/1005
9 years, 2 months ago (2011-10-24 17:56:27 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 20:01:50 UTC) #7
Change committed as 106962

Powered by Google App Engine
This is Rietveld 408576698