[Linux] Load plugins out-of-process.

content/browser/plugin_loader_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/plugin_loader_posix.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
 #include "base/metrics/histogram.h"
@@ skipping 27 matching lines @@
     IPC_MESSAGE_HANDLER(UtilityHostMsg_LoadPluginFailed, OnPluginLoadFailed)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void PluginLoaderPosix::OnProcessCrashed(int exit_code) {
   canonical_list_.erase(canonical_list_.begin(),
                         canonical_list_.begin() + next_load_index_ + 1);
   next_load_index_ = 0;
-  LoadPluginsInternal();
+
+  if (!MaybeRunPendingCallbacks())
+    LoadPluginsInternal();

[Bernhard Bauer, 2011/10/24 14:57:08]

You could have the check for an empty canonical list in LoadPluginsInternal and
short-circuit to RunPendingCallbacks there. This would also catch the
(admittedly very esoteric) case that the canonical list of plug-ins starts out
empty.

[Robert Sesek, 2011/10/24 16:44:40]

Done.

 }
 
 bool PluginLoaderPosix::Send(IPC::Message* message) {
   return process_host_->Send(message);
 }
 
 PluginLoaderPosix::~PluginLoaderPosix() {
 }
 
 void PluginLoaderPosix::GetPluginsToLoad() {
@@ skipping 40 matching lines @@
     LOG(ERROR) << "Received unexpected plugin load message for "
                << plugin.path.value();
     return;
   }
 
   if (!MaybeAddInternalPlugin(plugin.path))
     loaded_plugins_.push_back(plugin);
 
   ++next_load_index_;
 
-  RunPendingCallbacks();
+  MaybeRunPendingCallbacks();
 }
 
 void PluginLoaderPosix::OnPluginLoadFailed(const FilePath& plugin_path) {
   if (plugin_path.value() != canonical_list_[next_load_index_].value()) {
     LOG(ERROR) << "Received unexpected plugin load failure message for "
                << plugin_path.value();
     return;
   }
 
   ++next_load_index_;
 
   MaybeAddInternalPlugin(plugin_path);
-  RunPendingCallbacks();
+  MaybeRunPendingCallbacks();
 }
 
 bool PluginLoaderPosix::MaybeAddInternalPlugin(const FilePath& plugin_path) {
   for (std::vector<webkit::WebPluginInfo>::iterator it =
            internal_plugins_.begin();
        it != internal_plugins_.end();
        ++it) {
     if (it->path == plugin_path) {
       loaded_plugins_.push_back(*it);
       internal_plugins_.erase(it);
       return true;
     }
   }
   return false;
 }
 
-void PluginLoaderPosix::RunPendingCallbacks() {
+bool PluginLoaderPosix::MaybeRunPendingCallbacks() {
   if (next_load_index_ < canonical_list_.size())
-    return;
+    return false;
 
   PluginList::Singleton()->SetPlugins(loaded_plugins_);
   for (std::vector<PendingCallback>::iterator it = callbacks_.begin();
        it != callbacks_.end();
        ++it) {
     it->target_loop->PostTask(FROM_HERE,
         base::Bind(it->callback, loaded_plugins_));
   }
   callbacks_.clear();
 
   HISTOGRAM_TIMES("PluginLoaderPosix.LoadDone",
                   (base::TimeTicks::Now() - load_start_time_)
                       * base::Time::kMicrosecondsPerMillisecond);
   load_start_time_ = base::TimeTicks();
+
+  return true;
 }
 
 PluginLoaderPosix::PendingCallback::PendingCallback(
     scoped_refptr<base::MessageLoopProxy> loop,
     const PluginService::GetPluginsCallback& cb)
     : target_loop(loop),
       callback(cb) {
 }
 
 PluginLoaderPosix::PendingCallback::~PendingCallback() {
 }