Issue 8371019: Fix a URI related problem on windows.

Issue 8371019: Fix a URI related problem on windows. (Closed)

Created:
9 years, 2 months ago by devoncarew

Modified:
9 years, 2 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org, codefu

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Description

Fix a URI related problem on windows. Committed: https://code.google.com/p/dart/source/detail?r=626

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/DartLibraryImpl.java	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/compiler/TestCompilerListener.java	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM! Thanks for tracking this down! http://codereview.chromium.org/8371019/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java (right): http://codereview.chromium.org/8371019/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java#newcode50 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java:50: DartCore.logError(ex); Please add ...

9 years, 2 months ago (2011-10-22 15:44:09 UTC) #2

devoncarew

http://codereview.chromium.org/8371019/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java (right): http://codereview.chromium.org/8371019/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java#newcode50 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/util/ResourceUtil.java:50: DartCore.logError(ex); SGTM - done.

9 years, 2 months ago (2011-10-22 17:26:23 UTC) #3

lgtm

Expand Messages | Collapse Messages