chrome/browser/resources/print_preview/page_settings.html - Issue 8371017: Print Preview: Changing the structure of the html/css.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/page_settings.html

Issue 8371017: Print Preview: Changing the structure of the html/css. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactoring css class displaytable, removing class displaytablerow Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/options_page.css ('K') | « chrome/browser/resources/print_preview/margin_settings.js ('k') | chrome/browser/resources/print_preview/page_settings.js » ('j') | chrome/browser/resources/print_preview/print_preview.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/page_settings.html

diff --git a/chrome/browser/resources/print_preview/page_settings.html b/chrome/browser/resources/print_preview/page_settings.html

index 12d0beb0168b39b539e7cefca3ca2b2125743019..08ecd5fc37a0c49565d461dfe8a05b12e8eb4c41 100644

--- a/chrome/browser/resources/print_preview/page_settings.html

+++ b/chrome/browser/resources/print_preview/page_settings.html

@@ -1,19 +1,21 @@

-<div class="two-column">

+<div class="two-column visible">

- <div>

- <input id="all-pages" name="pages" checked type="radio"/>

- <label for="all-pages" i18n-content="optionAllPages"></label>

- </div>

- <div>

- <div id="print-pages-div">

- <input id="print-pages" name="pages" type="radio"

- i18n-values="aria-label:printPagesLabel;"/>

- <input id="individual-pages" type="text"

- i18n-values="placeholder:examplePageRangeText"/>

+ <div class="right-column">

+ <div>

+ <input id="all-pages" name="pages" checked type="radio"/>

James Hawkins 2011/10/25 01:13:32 nit: Don't close single tags. Here and everywhere

dpapad 2011/10/25 15:36:12 Done.

+ <label for="all-pages" i18n-content="optionAllPages"></label>

+ </div>

+ <div>

+ <div id="print-pages-div">

+ <input id="print-pages" name="pages" type="radio"

+ i18n-values="aria-label:printPagesLabel;"/>

+ <input id="individual-pages" type="text"

+ i18n-values="placeholder:examplePageRangeText"/>

+ </div>

+ <span id="individual-pages-hint" class="hint"

+ i18n-content="pageRangeInstruction" aria-hidden="true"

+ aria-live="polite">

+ </span>

</div>

- <span id="individual-pages-hint" class="hint"

- i18n-content="pageRangeInstruction" aria-hidden="true"

- aria-live="polite">

- </span>

</div>