chrome/browser/resources/print_preview/page_settings.html - Issue 8371017: Print Preview: Changing the structure of the html/css.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/print_preview/page_settings.html

Issue 8371017: Print Preview: Changing the structure of the html/css. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactoring css class displaytable, removing class displaytablerow Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/options/options_page.css ('K') | « chrome/browser/resources/print_preview/margin_settings.js ('k') | chrome/browser/resources/print_preview/page_settings.js » ('j') | chrome/browser/resources/print_preview/print_preview.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div class="two-column">	1 <div class="two-column visible">

2 <h1 i18n-content="pagesLabel"></h1>	2 <h1 i18n-content="pagesLabel"></h1>

3 <div>	3 <div class="right-column">

4 <input id="all-pages" name="pages" checked type="radio"/>	4 <div>

5 <label for="all-pages" i18n-content="optionAllPages"></label>	5 <input id="all-pages" name="pages" checked type="radio"/>
	James Hawkins 2011/10/25 01:13:32 nit: Don't close single tags. Here and everywhere nit: Don't close single tags. Here and everywhere else. dpapad 2011/10/25 15:36:12 Done. Show quoted text On 2011/10/25 01:13:32, James Hawkins wrote: > nit: Don't close single tags. Here and everywhere else. Done.
6 </div>	6 <label for="all-pages" i18n-content="optionAllPages"></label>

7 <div>

8 <div id="print-pages-div">

9 <input id="print-pages" name="pages" type="radio"

10 i18n-values="aria-label:printPagesLabel;"/>

11 <input id="individual-pages" type="text"

12 i18n-values="placeholder:examplePageRangeText"/>

13 </div>	7 </div>

14 <span id="individual-pages-hint" class="hint"	8 <div>

15 i18n-content="pageRangeInstruction" aria-hidden="true"	9 <div id="print-pages-div">

16 aria-live="polite">	10 <input id="print-pages" name="pages" type="radio"

17 </span>	11 i18n-values="aria-label:printPagesLabel;"/>

	12 <input id="individual-pages" type="text"

	13 i18n-values="placeholder:examplePageRangeText"/>

	14 </div>

	15 <span id="individual-pages-hint" class="hint"

	16 i18n-content="pageRangeInstruction" aria-hidden="true"

	17 aria-live="polite">

	18 </span>

	19 </div>

18 </div>	20 </div>

19 </div>	21 </div>

OLD	NEW