Convert the non-debug logging in chrome/common to debug logging.

Convert the non-debug logging in chrome/common to debug logging.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107815

[Ami GONE FROM CHROMIUM, 2011-10-22 20:10:25]

drive-by

Your email to chromium-dev and the CL description both talked about "logging"
and I assumed you were talking about loglevels at ERROR and below.  FATAL seems
like a different beast to me and subject to different considerations so I am
surprised to see this CL touch CHECK*'s.

http://codereview.chromium.org/8370022/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator.cc (right):

http://codereview.chromium.org/8370022/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator.cc:342:
DCHECK_EQ(output_buffers_at_component_, 0);
This (and elsewhere in this file) is not a logging-only change.
These CHECKs are here to crash the GPU process instead of running off the rails
at some future time.  Esp. b/c this is code that interacts with the GPU (where
running off the rails can be more impactful on the rest of the system than most
code in chromium) I'd like to keep the existing CHECKs.

[brettw, 2011-10-25 02:10:12]

http://codereview.chromium.org/8370022/diff/1/content/common/gpu/media/omx_vi...
File content/common/gpu/media/omx_video_decode_accelerator.cc (right):

http://codereview.chromium.org/8370022/diff/1/content/common/gpu/media/omx_vi...
content/common/gpu/media/omx_video_decode_accelerator.cc:342:
DCHECK_EQ(output_buffers_at_component_, 0);
I kept most of the checks in the GPU process. These seemed like they were
validating programming assumptions (like pictures_ = 0) rather than hardware
ones. Some code abuses CHECK so I changed the ones I thought looked particularly
suspicious like these:
http://codereview.chromium.org/8368018/diff/1/chrome/common/extensions/extens...

I'm happy to put back any you think are actually hardware related or important
to crash.

[jam, 2011-10-25 05:43:45]

lgtm

[Ami GONE FROM CHROMIUM, 2011-10-25 17:29:50]

> I kept most of the checks in the GPU process.

Ok.