Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: content/common/net/url_fetcher.cc

Issue 8370022: Convert the non-debug logging in chrome/common to debug logging. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/net/url_fetcher.cc
===================================================================
--- content/common/net/url_fetcher.cc (revision 106774)
+++ content/common/net/url_fetcher.cc (working copy)
@@ -332,7 +332,7 @@
void URLFetcher::Core::TempFileWriter::CreateTempFile() {
DCHECK(core_->io_message_loop_proxy_->BelongsToCurrentThread());
- CHECK(file_message_loop_proxy_.get());
+ DCHECK(file_message_loop_proxy_.get());
base::FileUtilProxy::CreateTemporary(
file_message_loop_proxy_,
0, // No additional file flags.
@@ -548,14 +548,14 @@
void URLFetcher::Core::Start() {
DCHECK(delegate_loop_proxy_);
- CHECK(request_context_getter_) << "We need an URLRequestContext!";
+ DCHECK(request_context_getter_) << "We need an URLRequestContext!";
if (io_message_loop_proxy_) {
DCHECK_EQ(io_message_loop_proxy_,
request_context_getter_->GetIOMessageLoopProxy());
} else {
io_message_loop_proxy_ = request_context_getter_->GetIOMessageLoopProxy();
}
- CHECK(io_message_loop_proxy_.get()) << "We need an IO message loop proxy";
+ DCHECK(io_message_loop_proxy_.get()) << "We need an IO message loop proxy";
io_message_loop_proxy_->PostTask(
FROM_HERE, base::Bind(&Core::StartOnIOThread, this));
@@ -634,7 +634,7 @@
void URLFetcher::Core::AppendChunkToUpload(const std::string& content,
bool is_last_chunk) {
DCHECK(delegate_loop_proxy_);
- CHECK(io_message_loop_proxy_.get());
+ DCHECK(io_message_loop_proxy_.get());
io_message_loop_proxy_->PostTask(
FROM_HERE,
base::Bind(&Core::CompleteAddingUploadDataChunk, this, content,
@@ -770,7 +770,7 @@
return;
}
- CHECK(request_context_getter_);
+ DCHECK(request_context_getter_);
DCHECK(!request_.get());
g_registry.Get().AddURLFetcherCore(this);
@@ -818,8 +818,8 @@
// If we are writing the response to a file, the only caller
// of this function should have created it and not written yet.
- CHECK(!temp_file_writer_.get() ||
- temp_file_writer_->total_bytes_written() == 0);
+ DCHECK(!temp_file_writer_.get() ||
+ temp_file_writer_->total_bytes_written() == 0);
request_->Start();
}
@@ -874,7 +874,7 @@
}
void URLFetcher::Core::InformDelegateFetchIsComplete() {
- CHECK(delegate_loop_proxy_->BelongsToCurrentThread());
+ DCHECK(delegate_loop_proxy_->BelongsToCurrentThread());
if (delegate_) {
delegate_->OnURLFetchComplete(fetcher_);
}
@@ -1082,7 +1082,7 @@
}
const std::string& URLFetcher::GetResponseStringRef() const {
- CHECK(core_->response_destination_ == STRING);
+ DCHECK(core_->response_destination_ == STRING);
return core_->data_;
}
Property changes on: content/common/net/url_fetcher.cc
___________________________________________________________________
Deleted: svn:mergeinfo

Powered by Google App Engine
This is Rietveld 408576698