Issue 8369021: Revert: Internalize JSON chunk merging to trace_event.h API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8369021: Revert: Internalize JSON chunk merging to trace_event.h API. (Closed)

Created:
9 years, 2 months ago by Matt Perry

Modified:
9 years, 2 months ago

Reviewers:
jbates

CC:
chromium-reviews, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert: Internalize JSON chunk merging to trace_event.h API. BUG=100291 TEST=base_unittests, content_unittests Review URL: http://codereview.chromium.org/8355024 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106812

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+57 lines, -173 lines)			Patch
M	base/debug/trace_event.h	View	2 chunks	+1 line, -47 lines	0 comments	Download
M	base/debug/trace_event.cc	View	3 chunks	+2 lines, -43 lines	0 comments	Download
M	base/debug/trace_event_unittest.cc	View	10 chunks	+14 lines, -40 lines	0 comments	Download
M	chrome/browser/ui/webui/tracing_ui.cc	View	2 chunks	+5 lines, -12 lines	0 comments	Download
M	content/browser/trace_controller.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	content/browser/trace_controller.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/trace_subscriber_stdio.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	content/browser/trace_subscriber_stdio.cc	View	4 chunks	+21 lines, -15 lines	0 comments	Download
M	content/browser/trace_subscriber_stdio_unittest.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/common/child_trace_message_filter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/common/child_trace_message_filter.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TBR

This CL broke Linux compile.

Expand Messages | Collapse Messages