content/browser/trace_subscriber_stdio_unittest.cc - Issue 8369021: Revert: Internalize JSON chunk merging to trace_event.h API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/trace_subscriber_stdio_unittest.cc

Issue 8369021: Revert: Internalize JSON chunk merging to trace_event.h API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/trace_subscriber_stdio_unittest.cc

diff --git a/content/browser/trace_subscriber_stdio_unittest.cc b/content/browser/trace_subscriber_stdio_unittest.cc

index 92f360f3506f12213b4f9893d970b0b873c60e07..afced0de8846a9e3d204ac857d1848428d74b673 100644

--- a/content/browser/trace_subscriber_stdio_unittest.cc

+++ b/content/browser/trace_subscriber_stdio_unittest.cc

@@ -28,7 +28,7 @@ class TraceSubscriberStdioTest : public testing::Test {

} // namespace

-TEST_F(TraceSubscriberStdioTest, CanWriteDataToFile) {

+TEST_F(TraceSubscriberStdioTest, CanWriteBracketedDataToFile) {

TraceSubscriberStdio subscriber(trace_file_);

subscriber.OnTraceDataCollected("[foo]");

subscriber.OnTraceDataCollected("[bar]");

@@ -36,5 +36,7 @@ TEST_F(TraceSubscriberStdioTest, CanWriteDataToFile) {

subscriber.OnEndTracingComplete();

EXPECT_FALSE(subscriber.IsValid());

+ EXPECT_EQ("[foo,bar,]", ReadTraceFile());

}