Rebase BookmarkBubble on the new views bubble.

views/controls/textfield/textfield.cc

Index: views/controls/textfield/textfield.cc
diff --git a/views/controls/textfield/textfield.cc b/views/controls/textfield/textfield.cc
index 8eaa0deedaab6dd1f5692d2d768af0037ab98441..8086d0d60bb617bff7d0304dd7937af9161cb1ab 100644
--- a/views/controls/textfield/textfield.cc
+++ b/views/controls/textfield/textfield.cc
@@ -55,6 +55,7 @@ Textfield::Textfield()
       initialized_(false),
       horizontal_margins_were_set_(false),
       vertical_margins_were_set_(false),
+      select_all_on_focus_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
 }
@@ -73,6 +74,7 @@ Textfield::Textfield(StyleFlags style)
       initialized_(false),
       horizontal_margins_were_set_(false),
       vertical_margins_were_set_(false),
+      select_all_on_focus_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
   if (IsPassword())
@@ -387,6 +389,11 @@ void Textfield::OnFocus() {
     // keyboard messages.
     View::OnFocus();
   }
+
+  if (select_all_on_focus())
+    SelectAll();
+  else
+    ClearSelection();

[jennyz, 2011/11/10 18:08:33]

I still concern this may affect the
NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the code
after text_field_ might think this is a single click after all text is selected,
and it will clear the selection and just flash the mouse cursor. 

[jennyz, 2011/11/10 18:27:06]

Sorry I missed some detail in previous comment.
I still concern this may affect the
NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the code
in NativeTextfieldViews::OnMousePress()
after text_field_->RequestFocus() might think this is a single click after all
text is selected,
and it will clear the selection and just flash the mouse cursor. 
On 2011/11/10 18:08:33, jennyz wrote:
 I still concern this may affect the
 NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the
code
 after text_field_->RequestFocus() in NativeTextfieldViews::OnMousePressed might
think this is a single click after all text is selected,

 }
 
 void Textfield::OnBlur() {