Rebase BookmarkBubble on the new views bubble.

views/controls/textfield/textfield.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/controls/textfield/textfield.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gdk/gdkkeysyms.h>
 #endif
 
@@ skipping 37 matching lines @@
       read_only_(false),
       default_width_in_chars_(0),
       draw_border_(true),
       text_color_(SK_ColorBLACK),
       use_default_text_color_(true),
       background_color_(SK_ColorWHITE),
       use_default_background_color_(true),
       initialized_(false),
       horizontal_margins_were_set_(false),
       vertical_margins_were_set_(false),
+      select_all_on_focus_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
 }
 
 Textfield::Textfield(StyleFlags style)
     : native_wrapper_(NULL),
       controller_(NULL),
       style_(style),
       read_only_(false),
       default_width_in_chars_(0),
       draw_border_(true),
       text_color_(SK_ColorBLACK),
       use_default_text_color_(true),
       background_color_(SK_ColorWHITE),
       use_default_background_color_(true),
       initialized_(false),
       horizontal_margins_were_set_(false),
       vertical_margins_were_set_(false),
+      select_all_on_focus_(false),
       text_input_type_(ui::TEXT_INPUT_TYPE_TEXT) {
   set_focusable(true);
   if (IsPassword())
     SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
 }
 
 Textfield::~Textfield() {
 }
 
 void Textfield::SetController(TextfieldController* controller) {
@@ skipping 294 matching lines @@
   if (native_wrapper_)
     native_wrapper_->HandleFocus();
 
   // Forward the focus to the wrapper if it exists.
   if (!native_wrapper_ || !native_wrapper_->SetFocus()) {
     // If there is no wrapper or the wrapper didn't take focus, call
     // View::Focus to clear the native focus so that we still get
     // keyboard messages.
     View::OnFocus();
   }
+
+  if (select_all_on_focus())
+    SelectAll();
+  else
+    ClearSelection();

[jennyz, 2011/11/10 18:08:33]

I still concern this may affect the
NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the code
after text_field_ might think this is a single click after all text is selected,
and it will clear the selection and just flash the mouse cursor. 

[jennyz, 2011/11/10 18:27:06]

Sorry I missed some detail in previous comment.
I still concern this may affect the
NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the code
in NativeTextfieldViews::OnMousePress()
after text_field_->RequestFocus() might think this is a single click after all
text is selected,
and it will clear the selection and just flash the mouse cursor. 
On 2011/11/10 18:08:33, jennyz wrote:
 I still concern this may affect the
 NativeTextfieldViews::OnMousePressed()/OnMouseRelease() behavior, since the
code
 after text_field_->RequestFocus() in NativeTextfieldViews::OnMousePressed might
think this is a single click after all text is selected,

 }
 
 void Textfield::OnBlur() {
   if (native_wrapper_)
     native_wrapper_->HandleBlur();
 }
 
 void Textfield::GetAccessibleState(ui::AccessibleViewState* state) {
   state->role = ui::AccessibilityTypes::ROLE_TEXT;
   state->name = accessible_name_;
@@ skipping 44 matching lines @@
     }
 #endif
   }
 }
 
 std::string Textfield::GetClassName() const {
   return kViewClassName;
 }
 
 }  // namespace views