Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3749)

Unified Diff: chrome/browser/sync/sessions/unrecoverable_error_info.h

Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For review. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/unrecoverable_error_info.h
diff --git a/chrome/browser/sync/sessions/unrecoverable_error_info.h b/chrome/browser/sync/sessions/unrecoverable_error_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..cc282ef4e1441dbd807b577de7f8a5646c091268
--- /dev/null
+++ b/chrome/browser/sync/sessions/unrecoverable_error_info.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_
akalin 2011/10/25 03:20:06 I don't think this class really belongs in session
lipalani1 2011/10/26 00:12:13 added a todo. On 2011/10/25 03:20:06, akalin wrote
+#define CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_
+#pragma once
+
+#include <string>
+
+#include "base/location.h"
+#include "base/memory/scoped_ptr.h"
akalin 2011/10/25 03:20:06 remove this include
lipalani1 2011/10/26 00:12:13 Done.
+
+namespace browser_sync {
+namespace sessions {
+class UnrecoverableErrorInfo {
+ public:
+ UnrecoverableErrorInfo();
+ UnrecoverableErrorInfo(
+ const tracked_objects::Location& location,
+ const std::string& message);
+ ~UnrecoverableErrorInfo();
+
+ void Set(const tracked_objects::Location& location,
akalin 2011/10/25 03:20:06 Reset is probably a better name
lipalani1 2011/10/26 00:12:13 Done.
+ const std::string& message);
+
+ bool IsSet() const;
+
+ const tracked_objects::Location& location() const;
+ const std::string& message() const;
+
+ private:
+ tracked_objects::Location location_;
+ std::string message_;
+ bool set_;
akalin 2011/10/25 03:20:06 probably should be named is_set_
lipalani1 2011/10/26 00:12:13 Done.
+};
+
+} // namespace sessions
+} // namespace browser_sync
+
+#endif // CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698