Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/sync/sessions/unrecoverable_error_info.h

Issue 8366030: Introduce the plumbing necessary to report Unrecoverable error from model safe workers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For review. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_
akalin 2011/10/25 03:20:06 I don't think this class really belongs in session
lipalani1 2011/10/26 00:12:13 added a todo. On 2011/10/25 03:20:06, akalin wrote
6 #define CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_
7 #pragma once
8
9 #include <string>
10
11 #include "base/location.h"
12 #include "base/memory/scoped_ptr.h"
akalin 2011/10/25 03:20:06 remove this include
lipalani1 2011/10/26 00:12:13 Done.
13
14 namespace browser_sync {
15 namespace sessions {
16 class UnrecoverableErrorInfo {
17 public:
18 UnrecoverableErrorInfo();
19 UnrecoverableErrorInfo(
20 const tracked_objects::Location& location,
21 const std::string& message);
22 ~UnrecoverableErrorInfo();
23
24 void Set(const tracked_objects::Location& location,
akalin 2011/10/25 03:20:06 Reset is probably a better name
lipalani1 2011/10/26 00:12:13 Done.
25 const std::string& message);
26
27 bool IsSet() const;
28
29 const tracked_objects::Location& location() const;
30 const std::string& message() const;
31
32 private:
33 tracked_objects::Location location_;
34 std::string message_;
35 bool set_;
akalin 2011/10/25 03:20:06 probably should be named is_set_
lipalani1 2011/10/26 00:12:13 Done.
36 };
37
38 } // namespace sessions
39 } // namespace browser_sync
40
41 #endif // CHROME_BROWSER_SYNC_SESSIONS_UNRECOVERABLE_ERROR_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698