Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 8365018: Adjust workaround for mipmap-related OpenGL implementation bug on Mac OS X. (Closed)

Created:
9 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 2 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium, Zhenyao Mo
Visibility:
Public.

Description

Adjust workaround for mipmap-related OpenGL implementation bug on Mac OS X. BUG=101105 TEST=manually ran WebGL conformance test textures/texture-mips.html on NVIDIA and AMD GPUs on Mac OS Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106634

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
9 years, 2 months ago (2011-10-20 23:15:15 UTC) #1
greggman
http://codereview.chromium.org/8365018/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/8365018/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode3015 gpu/command_buffer/service/gles2_cmd_decoder.cc:3015: glTexParameteri(target, GL_TEXTURE_MIN_FILTER, GL_NEAREST_MIPMAP_NEAREST); It seems like there are 2 ...
9 years, 2 months ago (2011-10-20 23:27:37 UTC) #2
greggman
added that test. it passes https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/textures/texture-mips.html lgtm
9 years, 2 months ago (2011-10-20 23:33:28 UTC) #3
Ken Russell (switch to Gerrit)
9 years, 2 months ago (2011-10-20 23:36:24 UTC) #4
http://codereview.chromium.org/8365018/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8365018/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3015: glTexParameteri(target,
GL_TEXTURE_MIN_FILTER, GL_NEAREST_MIPMAP_NEAREST);
I believe it's neither, but a third possibility: the filter mode needs to have
been changed from the default at least once, and also needs to be set to
something requiring mipmaps.

Powered by Google App Engine
This is Rietveld 408576698