Make Mac Chromoting Disconnect Window look good for R2L systems.

Make Mac Chromoting Disconnect Window look good for R2L systems.

BUG=NONE
TEST=Try chromoting in arabic.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108360

[dmac, 2011-10-21 00:27:39]

On 2011/10/21 00:27:17, dmac wrote:

Sorry that was supposed to be 'PTAL'

[Jamie, 2011-10-21 00:44:35]

LGTM with a couple of suggestions.

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window...
File remoting/host/disconnect_window_mac.mm (right):

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window...
remoting/host/disconnect_window_mac.mm:127: =
remoting::DisconnectWindow::kMaximumConnectedNameWidthInPixels;
You could avoid duplicating this long id using min().

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window...
remoting/host/disconnect_window_mac.mm:198: if ([[self windowController]
respondsToSelector:@selector(isRToL)]) {
This might be clearer as a DCHECK.

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window...
remoting/host/disconnect_window_mac.mm:215: if ([[self window]
isKindOfClass:[DisconnectWindow class]]) {
ditto.

[Jamie, 2011-10-21 00:50:30]

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window.h
File remoting/host/disconnect_window.h (right):

http://codereview.chromium.org/8364025/diff/1/remoting/host/disconnect_window...
remoting/host/disconnect_window.h:18: kMaximumConnectedNameWidthInPixels = 400
Can we rename this? As it is, it suggests that it's the maximum width for the
name, not the entire message.

[commit-bot: I haz the power, 2011-10-21 17:35:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmaclach@chromium.org/8364025/4001

[commit-bot: I haz the power, 2011-10-21 18:14:05]

Try job failure for 8364025-4001 (retry) on linux_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-02 20:23:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmaclach@chromium.org/8364025/4001

[commit-bot: I haz the power, 2011-11-02 23:49:29]

Change committed as 108360