Activate IRT building on ARM for NaCl.

Activate IRT building on ARM for NaCl.

In order for this to be on for real, the PNaCl toolchain still needs to
available

Since NaCl is still turned off by default on ARM, this code should be a no-op
for all other cases.

This also moves the compilation a step forward for ARM. 
 
There is a bootstrap dependency on memset on ARM - so SYSROOT on the
ChromiumOS chroot is required to gain access to libc.

R=bradnelson,robertm
BUG=http://code.google.com/p/chromium/issues/detail?id=61695
BUG=http://code.google.com/p/chromium/issues/detail?id=38909
BUG=http://code.google.com/p/nativeclient/issues/detail?id=135


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106982

[jasonwkim, 2011-10-20 21:32:11]

PTAL

[noelallen_use_chromium, 2011-10-21 00:16:51]

I have some questions about your use of "arm" vs "arm-thumb2" and how this
affects what get's build by Chrome.

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:166: platform2 = {'arm': 'pnacl', 'x86-32': 'i686',
'x86-64': 'x86_64'}.get(platform, platform)
Inconsistent checks of arm and arm-thumb2

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:173: if platform in ('arm', 'arm-thumb2'):
nit: I think we typically use lists not tupples for this.

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:173: if platform in ('arm', 'arm-thumb2'):
and here.

http://codereview.chromium.org/8364019/diff/1/chrome/nacl.gypi
File chrome/nacl.gypi (right):

http://codereview.chromium.org/8364019/diff/1/chrome/nacl.gypi#newcode138
chrome/nacl.gypi:138: ['OS!="win" and target_arch=="arm"', {
Inconsistent check here.  You check for win, but in the previous scons you
didn't.

[jasonwkim, 2011-10-21 20:16:56]

PTAL

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:166: platform2 = {'arm': 'pnacl', 'x86-32': 'i686',
'x86-64': 'x86_64'}.get(platform, platform)
On 2011/10/21 00:16:51, noelallen wrote:
> Inconsistent checks of arm and arm-thumb2

fixed.

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:173: if platform in ('arm', 'arm-thumb2'):
On 2011/10/21 00:16:51, noelallen wrote:
> nit: I think we typically use lists not tupples for this.

fixed

http://codereview.chromium.org/8364019/diff/1/chrome/build_nacl_irt.py#newcod...
chrome/build_nacl_irt.py:173: if platform in ('arm', 'arm-thumb2'):
On 2011/10/21 00:16:51, noelallen wrote:
> and here.

fixed

http://codereview.chromium.org/8364019/diff/1/chrome/nacl.gypi
File chrome/nacl.gypi (right):

http://codereview.chromium.org/8364019/diff/1/chrome/nacl.gypi#newcode138
chrome/nacl.gypi:138: ['OS!="win" and target_arch=="arm"', {
On 2011/10/21 00:16:51, noelallen wrote:
> Inconsistent check here.  You check for win, but in the previous scons you
> didn't.


I am just following the established pattern. First case was 
OS == win and arch== x86.
The rest of the cases including what I added are all 

OS != win and arch == x86/arm ...

[bradn, 2011-10-24 19:20:07]

Otherwise LGTM

http://codereview.chromium.org/8364019/diff/5001/chrome/build_nacl_irt.py
File chrome/build_nacl_irt.py (right):

http://codereview.chromium.org/8364019/diff/5001/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:184: '../native_client/scons-out/nacl_irt-' + platform
+ '/staging/irt.nexe',
>80

http://codereview.chromium.org/8364019/diff/5001/chrome/build_nacl_irt.py#new...
chrome/build_nacl_irt.py:192: '../native_client/scons-out/nacl_irt-' + platform
+ '/staging/irt.nexe',
>80

[commit-bot: I haz the power, 2011-10-24 19:26:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jasonwkim@google.com/8364019/8001

[commit-bot: I haz the power, 2011-10-24 19:41:13]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for diner.
Ping the relevant dude on a on-needed basis.

[commit-bot: I haz the power, 2011-10-24 20:05:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jasonwkim@google.com/8364019/9003

[commit-bot: I haz the power, 2011-10-24 20:08:54]

Try job failure for 8364019-9003 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-10-24 20:14:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jasonwkim@google.com/8364019/12001

[commit-bot: I haz the power, 2011-10-24 21:55:04]

Change committed as 106982