Activate IRT building on ARM for NaCl.

chrome/build_nacl_irt.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import optparse
 import os
 import re
 import shutil
 import subprocess
@@ skipping 145 matching lines @@
       devnull = open(os.devnull, 'r')
     else:
       devnull = None
     p = subprocess.Popen(cmd, cwd=NACL_DIR, stdin=devnull)
     p.wait()
     if p.returncode != 0:
       sys.exit(3)
   # Copy out each platform after stripping.
   for platform in platforms:
     uplatform = platform.replace('-', '_')
-    platform2 = {'x86-32': 'i686', 'x86-64': 'x86_64'}.get(platform, platform)
+    platform2 = {'arm': 'pnacl', 'x86-32': 'i686', 'x86-64': 'x86_64'}.get(platform, platform)

[noelallen_use_chromium, 2011/10/21 00:16:51]

Inconsistent checks of arm and arm-thumb2

[jasonwkim, 2011/10/21 20:16:56]

fixed.

     cplatform = {
         'win32': 'win',
         'cygwin': 'win',
         'darwin': 'mac',
     }.get(sys.platform, 'linux')
     nexe = os.path.join(out_dir, 'nacl_irt_' + uplatform + '.nexe')
-    cmd = [
-      '../native_client/toolchain/' + cplatform + '_x86_newlib/bin/' +
+    if platform in ('arm', 'arm-thumb2'):

[noelallen_use_chromium, 2011/10/21 00:16:51]

nit: I think we typically use lists not tupples for this.

[noelallen_use_chromium, 2011/10/21 00:16:51]

and here.

[jasonwkim, 2011/10/21 20:16:56]

fixed

[jasonwkim, 2011/10/21 20:16:56]

fixed

+      cmd = [
+          '../native_client/toolchain/pnacl_linux_x86_64_newlib/bin/' +
+          platform2 + '-strip',
+          '--strip-debug',
+          '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
+          '-o', nexe
+          ]
+    else:
+      cmd = [
+          '../native_client/toolchain/' + cplatform + '_x86_newlib/bin/' +
           platform2 + '-nacl-strip',
-      '--strip-debug',
-      '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
-      '-o', nexe
-    ]
+          '--strip-debug',
+          '../native_client/scons-out/nacl_irt-' + platform + '/staging/irt.nexe',
+          '-o', nexe
+          ]
     print 'Running: ' + ' '.join(cmd)
     p = subprocess.Popen(cmd, cwd=SCRIPT_DIR)
     p.wait()
     if p.returncode != 0:
       sys.exit(4)
 
 
 def Main(argv):
   parser = optparse.OptionParser()
   parser.add_option('--inputs', dest='inputs', default=False,
@@ skipping 11 matching lines @@
     sys.exit(1)
 
   if options.inputs:
     PrintInputs(options.platforms)
   else:
     BuildIRT(options.platforms, options.outdir)
 
 
 if __name__ == '__main__':
   Main(sys.argv)