Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3684)

Unified Diff: chrome/browser/autocomplete/extension_app_provider_unittest.cc

Issue 8364001: Strip special characters in extension omnibox suggestions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/extension_app_provider_unittest.cc
===================================================================
--- chrome/browser/autocomplete/extension_app_provider_unittest.cc (revision 107110)
+++ chrome/browser/autocomplete/extension_app_provider_unittest.cc (working copy)
@@ -105,3 +105,26 @@
RunTest(edit_cases, ARRAYSIZE_UNSAFE(edit_cases));
}
+
+TEST_F(ExtensionAppProviderTest, CreateMatchSanitize) {
+ struct TestData {
+ const char* name;
+ const char* match_contents;
+ } cases[] = {
+ { "Test", "Test" },
+ { "Test \n Test", "Test Test" },
+ { "Test\r\t\nTest", "TestTest" },
+ };
+
+ AutocompleteInput input(ASCIIToUTF16("Test"), ASCIIToUTF16(""),
Peter Kasting 2011/10/25 20:37:07 Nit: ASCIIToUTF16("") -> string16()
Alexei Svitkine (slow) 2011/10/25 21:37:16 Done.
+ true, true, true, AutocompleteInput::BEST_MATCH);
+ string16 url(ASCIIToUTF16("http://example.com"));
+ for (size_t i = 0; i < ARRAYSIZE_UNSAFE(cases); ++i) {
+ AutocompleteMatch match =
+ app_provider_->CreateAutocompleteMatch(input,
+ ASCIIToUTF16(cases[i].name),
+ url, 0, string16::npos);
+ EXPECT_EQ(ASCIIToUTF16(cases[i].match_contents), match.contents);
+ }
+}
+

Powered by Google App Engine
This is Rietveld 408576698