Strip special characters in extension omnibox suggestions.

chrome/browser/autocomplete/extension_app_provider.h

Index: chrome/browser/autocomplete/extension_app_provider.h
===================================================================
--- chrome/browser/autocomplete/extension_app_provider.h	(revision 107110)
+++ chrome/browser/autocomplete/extension_app_provider.h	(working copy)
@@ -20,6 +20,7 @@
 #include <vector>
 
 #include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
 #include "chrome/browser/autocomplete/autocomplete.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "content/public/browser/notification_observer.h"
@@ -45,6 +46,13 @@
 
   virtual ~ExtensionAppProvider();
 
+  // Construct a match for the specified parameters.
+  AutocompleteMatch CreateAutocompleteMatch(const AutocompleteInput& input,

[Peter Kasting, 2011/10/25 20:37:07]

Nit: I'm not sure the benefit of this method is very large.  It's a little
unwieldy for the test code to call since the test only cares about sanitizing
the contents but this method is worried about the whole match.  Given the checks
in autocomplete.cc, I would probably just revert the changes to this file and
the unittest and merely add a sanitize call where the match is currently being
constructed.

[Alexei Svitkine (slow), 2011/10/25 21:37:16]

While I understand your point view, I disagree. I think, having this in a
separate function makes the calling code more readable and maintainable - so
thing change is worth it just for that.

I agree that there's less need for a unit test with the DCHECK()s in place, but
I still feel having them is better than not (especially since they're written
already). First, the test is next to the source file in question - rather than a
DCHECK() in some other file that relies on someone hitting that path to be
caught - which requires running e.g. an extension that actually does this. Also,
who knows how the other file will get refactored in the future - it is possible
that the DCHECK() may get lost.

+                                            const string16& name,
+                                            const string16& url,
+                                            size_t name_match_index,
+                                            size_t url_match_index);
+
   // Fetch the current app list and cache it locally.
   void RefreshAppList();
 
@@ -68,6 +76,8 @@
   // apps we know about.
   ExtensionApps extension_apps_;
 
+  FRIEND_TEST_ALL_PREFIXES(ExtensionAppProviderTest, CreateMatchSanitize);
+
   DISALLOW_COPY_AND_ASSIGN(ExtensionAppProvider);
 };