Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 8363047: Aura: fix crash when clicking on a SELECT element. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Aura: fix crash when clicking on a SELECT element. This fix doesn't display selection popups properly, though (because RenderWidgetHostViewAura::InitAsPopup is not implemented). BUG=101899, 99757 TEST=Manual: click on any SELECT element Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107571

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Korotkov
PTAL
9 years, 1 month ago (2011-10-27 12:51:30 UTC) #1
Ben Goodger (Google)
9 years, 1 month ago (2011-10-27 14:19:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698