Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 8363047: Aura: fix crash when clicking on a SELECT element. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_aura.h" 5 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/browser/renderer_host/backing_store_skia.h" 8 #include "content/browser/renderer_host/backing_store_skia.h"
9 #include "content/browser/renderer_host/web_input_event_aura.h" 9 #include "content/browser/renderer_host/web_input_event_aura.h"
10 #include "content/browser/renderer_host/render_widget_host.h" 10 #include "content/browser/renderer_host/render_widget_host.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 window_->Init(ui::Layer::LAYER_HAS_TEXTURE); 88 window_->Init(ui::Layer::LAYER_HAS_TEXTURE);
89 } 89 }
90 90
91 //////////////////////////////////////////////////////////////////////////////// 91 ////////////////////////////////////////////////////////////////////////////////
92 // RenderWidgetHostViewAura, RenderWidgetHostView implementation: 92 // RenderWidgetHostViewAura, RenderWidgetHostView implementation:
93 93
94 void RenderWidgetHostViewAura::InitAsPopup( 94 void RenderWidgetHostViewAura::InitAsPopup(
95 RenderWidgetHostView* parent_host_view, 95 RenderWidgetHostView* parent_host_view,
96 const gfx::Rect& pos) { 96 const gfx::Rect& pos) {
97 NOTIMPLEMENTED(); 97 NOTIMPLEMENTED();
98 // TODO(ivankr): there has to be an Init() call, otherwise |window_|
99 // is left uninitialized and will eventually crash.
100 Init();
98 } 101 }
99 102
100 void RenderWidgetHostViewAura::InitAsFullscreen( 103 void RenderWidgetHostViewAura::InitAsFullscreen(
101 RenderWidgetHostView* reference_host_view) { 104 RenderWidgetHostView* reference_host_view) {
102 NOTIMPLEMENTED(); 105 NOTIMPLEMENTED();
106 // TODO(ivankr): there has to be an Init() call, otherwise |window_|
107 // is left uninitialized and will eventually crash.
108 Init();
103 } 109 }
104 110
105 RenderWidgetHost* RenderWidgetHostViewAura::GetRenderWidgetHost() const { 111 RenderWidgetHost* RenderWidgetHostViewAura::GetRenderWidgetHost() const {
106 return host_; 112 return host_;
107 } 113 }
108 114
109 void RenderWidgetHostViewAura::DidBecomeSelected() { 115 void RenderWidgetHostViewAura::DidBecomeSelected() {
110 host_->WasRestored(); 116 host_->WasRestored();
111 } 117 }
112 118
(...skipping 347 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 } 466 }
461 #endif 467 #endif
462 468
463 //////////////////////////////////////////////////////////////////////////////// 469 ////////////////////////////////////////////////////////////////////////////////
464 // RenderWidgetHostViewAura, private: 470 // RenderWidgetHostViewAura, private:
465 471
466 void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() { 472 void RenderWidgetHostViewAura::UpdateCursorIfOverSelf() {
467 //NOTIMPLEMENTED(); 473 //NOTIMPLEMENTED();
468 // TODO(beng): See RenderWidgetHostViewWin. 474 // TODO(beng): See RenderWidgetHostViewWin.
469 } 475 }
OLDNEW
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698