Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 8363036: ui/gfx: Change Canvas::ScaleInt() to just Canvas::Scale(). (Closed)

Created:
9 years, 1 month ago by tfarina
Modified:
9 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, asanka, dhollowa, Randy Smith (Not in Mondays), Paweł Hajdan Jr.
Visibility:
Public.

Description

ui/gfx: Change Canvas::ScaleInt() to just Canvas::Scale(). BUG=100898 R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107559

Patch Set 1 #

Patch Set 2 : address Peter's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/browser/ui/views/download/download_item_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/dragged_tab_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/canvas_direct2d.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_direct2d.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/canvas_direct2d_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_skia.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/canvas_skia.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_image_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
9 years, 1 month ago (2011-10-27 00:34:24 UTC) #1
Peter Kasting
I don't think we should change this to take a Point, because the arguments really ...
9 years, 1 month ago (2011-10-27 00:42:29 UTC) #2
tfarina
On 2011/10/27 00:42:29, Peter Kasting wrote: > I don't think we should change this to ...
9 years, 1 month ago (2011-10-27 00:48:59 UTC) #3
Peter Kasting
9 years, 1 month ago (2011-10-27 00:53:03 UTC) #4
LGTM

It's interesting to me that outside of a test, we only ever Scale(-1, 1). 
Perhaps we should consider replacing the Scale() function with some sort of a
"mirror" call that just does this.  Dunno if that's actually a good idea.

Powered by Google App Engine
This is Rietveld 408576698