NTP4/Sync Promo:

NTP4/Sync Promo:
- rename sync promo -> NTP sign-in promo
- re-arrange UMA to correctly report stuff given new code path
- re-fix pane switcher issue.

R=sail@chromium.org,estade@chromium.org
TBR=mirandac@chromium.org
BUG=99540
TEST=Unit tests still pass, code still compiles, UMA gets reported, and pane switchers don't obscure.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107517

[Dan Beam, 2011-10-27 00:13:04]

Might wanna wait one sec while I merge my changes with sail@'s r107472 (there
will be conflicts, pretty sure).

[sail, 2011-10-27 00:55:31]

lgtm

[Dan Beam, 2011-10-27 00:58:10]

NOTE -

Renaming / nits:
- promo_resource_service*
- pref_names.*
- sync_promo_ui.cc

Pane switcher bug:
- new_tab*

UMA / more renaming & nits:
- ntp_login_handler.*

[Dan Beam, 2011-10-27 01:07:55]

http://codereview.chromium.org/8363035/diff/2001/chrome/common/pref_names.h
File chrome/common/pref_names.h (right):

http://codereview.chromium.org/8363035/diff/2001/chrome/common/pref_names.h#n...
chrome/common/pref_names.h:469: extern const char kNTPSignInPromoGroupMax[];
I should note here that these have never been set, as we've never actually
turned on a response from the server-side yet.  So, this is the one and only
time we can rename them without needing to migrate (or be locked to the old,
ambiguous name).

[Evan Stade, 2011-10-27 01:08:32]

lgtm

[commit-bot: I haz the power, 2011-10-27 01:13:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/8363035/2001

[commit-bot: I haz the power, 2011-10-27 02:19:27]

Change committed as 107517

[Dan Beam, 2011-10-27 02:23:36]

mirandac: Just let me know if you have any comments and we can see if we can
merge them (if major).  The stuff I wanted you to review was mainly
PromoResourceService.* and NTPPromoSignInTest.* stuff, and it's really just a
huge rename (same tests pass).

[Miranda Callahan, 2011-10-27 17:20:15]

On 2011/10/27 02:23:36, Dan Beam wrote:
> mirandac: Just let me know if you have any comments and we can see if we can
> merge them (if major).  The stuff I wanted you to review was mainly
> PromoResourceService.* and NTPPromoSignInTest.* stuff, and it's really just a
> huge rename (same tests pass).

LGTM from me as well -- merge on!