NTP4/Sync Promo:

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 46 matching lines @@
                               const content::NotificationSource& source,
                               const content::NotificationDetails& details) {
   DCHECK(type == chrome::NOTIFICATION_PREF_CHANGED);
   std::string* name = content::Details<std::string>(details).ptr();
   if (prefs::kGoogleServicesUsername == *name)
     UpdateLogin();
 }
 
 void NTPLoginHandler::HandleInitializeSyncLogin(const ListValue* args) {
   UpdateLogin();
-  UMA_HISTOGRAM_ENUMERATION("SyncPromo.NTPPromo",
-                            SYNC_PROMO_NTP_PROMO_VIEWED,
-                            SYNC_PROMO_NTP_PROMO_BUCKET_BOUNDARY);
 }
 
 void NTPLoginHandler::HandleShowSyncLoginUI(const ListValue* args) {
   Profile* profile = Profile::FromWebUI(web_ui_);
   std::string username = profile->GetPrefs()->GetString(
       prefs::kGoogleServicesUsername);
 
   if (username.empty()) {
     // The user isn't signed in, show the sync promo.
     if (SyncPromoUI::ShouldShowSyncPromo(profile)) {
-      UMA_HISTOGRAM_ENUMERATION("SyncPromo.NTPPromo",
-                                SYNC_PROMO_NTP_PROMO_CLICKED,
-                                SYNC_PROMO_NTP_PROMO_BUCKET_BOUNDARY);
       web_ui_->tab_contents()->OpenURL(GURL(chrome::kChromeUISyncPromoURL),
                                        GURL(), CURRENT_TAB,
                                        content::PAGE_TRANSITION_LINK);
+      RecordInHistogram(NTP_SIGN_IN_PROMO_CLICKED);
     }
   } else if (args->GetSize() == 4) {
     // The user is signed in, show the profiles menu.
     Browser* browser =
         BrowserList::FindBrowserWithTabContents(web_ui_->tab_contents());
     if (!browser)
       return;
     double x = 0;
     double y = 0;
     double width = 0;
     double height = 0;
     bool success = args->GetDouble(0, &x);
     DCHECK(success);
     success = args->GetDouble(1, &y);
     DCHECK(success);
     success = args->GetDouble(2, &width);
     DCHECK(success);
     success = args->GetDouble(3, &height);
     DCHECK(success);
     gfx::Rect rect(x, y, width, height);
     browser->window()->ShowAvatarBubble(web_ui_->tab_contents(), rect);
   }
 }
 
+void NTPLoginHandler::RecordInHistogram(int type) {
+  // Invalid type to record.
+  if (type < NTP_SIGN_IN_PROMO_VIEWED ||
+      type > NTP_SIGN_IN_PROMO_CLICKED) {
+    NOTREACHED();
+  } else {
+    UMA_HISTOGRAM_ENUMERATION("SyncPromo.NTPPromo", type,
+                              NTP_SIGN_IN_PROMO_BUCKET_BOUNDARY);
+  }
+}
+
 void NTPLoginHandler::UpdateLogin() {
   Profile* profile = Profile::FromWebUI(web_ui_);
   std::string username = profile->GetPrefs()->GetString(
       prefs::kGoogleServicesUsername);
   string16 header, sub_header;
   if (!username.empty()) {
     header = UTF8ToUTF16(username);
   } else if (SyncPromoUI::ShouldShowSyncPromo(profile) &&
              (SyncPromoUI::UserHasSeenSyncPromoAtStartup(profile) ||
-              PromoResourceService::CanShowSyncPromo(profile))) {
+              PromoResourceService::CanShowNTPSignInPromo(profile))) {
     string16 signed_in_link = l10n_util::GetStringUTF16(
         IDS_SYNC_PROMO_NOT_SIGNED_IN_STATUS_LINK);
     signed_in_link = ASCIIToUTF16("<span class='link-span'>") + signed_in_link +
                      ASCIIToUTF16("</span>");
     header = l10n_util::GetStringFUTF16(
         IDS_SYNC_PROMO_NOT_SIGNED_IN_STATUS_HEADER,
         l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME));
     sub_header = l10n_util::GetStringFUTF16(
         IDS_SYNC_PROMO_NOT_SIGNED_IN_STATUS_SUB_HEADER, signed_in_link);
+    // Record that the user was shown the promo.
+    RecordInHistogram(NTP_SIGN_IN_PROMO_VIEWED);
   }
 
   StringValue header_value(header);
   StringValue sub_header_value(sub_header);
   web_ui_->CallJavascriptFunction(
       "updateLogin", header_value, sub_header_value);
 }
 
+// static
 bool NTPLoginHandler::ShouldShow(Profile* profile) {
 #if defined(OS_CHROMEOS)
   // For now we don't care about showing sync status on Chrome OS. The promo
   // UI and the avatar menu don't exist on that platform.
   return false;
 #else
   if (profile->IsOffTheRecord())
     return false;
 
   return profile->GetOriginalProfile()->IsSyncAccessible();
 #endif
 }