Restricting set of URL requests that get intercepted to gview to GET methods with scheme http

Restricting set of URL requests that get intercepted to gview to GET methods with scheme http

This should not affect official build since requests with pdf mime type already don't get intercepted when pdf plugin is present.

TEST=Verified pdf can be copied in chromium OS file browser.
     unit_tests:GViewRequestInterceptorTest.*
BUG=chromium-os:21560
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107991

[zel, 2011-10-19 21:57:49]

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor.cc (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor.cc:84: return scheme ==
"http";
there is a constant for chrome scheme already defined somewhere in Chrome code
base, grep for places where scheme() is used.

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor.h (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor.h:21: class
GViewRequestInterceptor : public net::URLRequestJobFactory::Interceptor {
we should also remove this interceptor from the official release. we don't need
it for anything else than chromium builds. check where we instantiate it and
make sure that happens only when:

#if !defined(GOOGLE_CHROME_BUILD)

[Scott Byer, 2011-10-19 22:11:01]

http://codereview.chromium.org/8357019/diff/1/chrome/browser/extensions/file_...
File chrome/browser/extensions/file_manager_util.cc (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/extensions/file_...
chrome/browser/extensions/file_manager_util.cc:47: ".pdf",
Chromium can support PDF in a tab if the plug in is copied over from an official
build; this can be useful for testing. I think this should be left the way it
had been, things should be switched based on if the plug-in is available.

[tbarzic, 2011-10-19 23:30:27]

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor.cc (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor.cc:84: return scheme ==
"http";
On 2011/10/19 21:57:49, zel wrote:
> there is a constant for chrome scheme already defined somewhere in Chrome code
> base, grep for places where scheme() is used. 

Done.

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor.h (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor.h:21: class
GViewRequestInterceptor : public net::URLRequestJobFactory::Interceptor {
On 2011/10/19 21:57:49, zel wrote:
> we should also remove this interceptor from the official release. we don't
need
> it for anything else than chromium builds. check where we instantiate it and
> make sure that happens only when:
> 
> #if !defined(GOOGLE_CHROME_BUILD)

Done.

http://codereview.chromium.org/8357019/diff/1/chrome/browser/extensions/file_...
File chrome/browser/extensions/file_manager_util.cc (right):

http://codereview.chromium.org/8357019/diff/1/chrome/browser/extensions/file_...
chrome/browser/extensions/file_manager_util.cc:47: ".pdf",
On 2011/10/19 22:11:02, Scott Byer wrote:
> Chromium can support PDF in a tab if the plug in is copied over from an
official
> build; this can be useful for testing. I think this should be left the way it
> had been, things should be switched based on if the plug-in is available.

If we leave thing as they are, opening pdf file in file browser would start
download of that file (if pdf plugin is not enabled).

[Scott Byer, 2011-10-19 23:34:03]

lgtm

[commit-bot: I haz the power, 2011-10-27 21:37:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8357019/7001

[commit-bot: I haz the power, 2011-10-27 21:37:54]

Presubmit check for 8357019-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/profiles/profile_io_data.cc

Presubmit checks took 1.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[tbarzic, 2011-10-27 21:44:16]

Dave, I need an approval from an owner for
chrome/browser/profiles/profile_io_data.cc

[DaveMoore, 2011-10-28 18:47:09]

lgtm

http://codereview.chromium.org/8357019/diff/7001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_io_data.cc (right):

http://codereview.chromium.org/8357019/diff/7001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_io_data.cc:477: #endif  // defined(OS_CHROMEOS)
&& !defiend(GOOGLE_CHROME_BUILD)
Nit: spelling

[commit-bot: I haz the power, 2011-10-31 17:36:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8357019/2003

[commit-bot: I haz the power, 2011-10-31 17:37:14]

Can't apply patch for file chrome/browser/extensions/file_manager_util.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/file_manager_util.cc
Hunk #1 FAILED at 7.
1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/extensions/file_manager_util.cc.rej

[commit-bot: I haz the power, 2011-10-31 17:51:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8357019/18001

[commit-bot: I haz the power, 2011-10-31 19:24:43]

Change committed as 107991