Restricting set of URL requests that get intercepted to gview to GET methods with scheme http

chrome/browser/chromeos/gview_request_interceptor.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/gview_request_interceptor.h"
 
 #include "base/file_path.h"
 #include "base/path_service.h"
 #include "chrome/browser/chrome_plugin_service_filter.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/browser/plugin_service.h"
 #include "content/browser/renderer_host/resource_dispatcher_host.h"
 #include "content/browser/renderer_host/resource_dispatcher_host_request_info.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/escape.h"
 #include "net/base/load_flags.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_redirect_job.h"
 #include "webkit/plugins/webplugininfo.h"
 
 namespace chromeos {
 
+namespace {
+
 // The PDF mime type is treated special if the browser has a built-in
 // PDF viewer plug-in installed - we want to intercept only if we're
 // told to.
-static const char kPdfMimeType[] = "application/pdf";
+const char kPdfMimeType[] = "application/pdf";
 
 // This is the list of mime types currently supported by the Google
 // Document Viewer.
-static const char* const kSupportedMimeTypeList[] = {
+const char* const kSupportedMimeTypeList[] = {
   kPdfMimeType,
   "application/vnd.ms-powerpoint"
 };
 
-static const char kGViewUrlPrefix[] = "http://docs.google.com/gview?url=";
+const char kGViewUrlPrefix[] = "http://docs.google.com/gview?url=";
+
+}  // namespace
 
 GViewRequestInterceptor::GViewRequestInterceptor() {
   for (size_t i = 0; i < arraysize(kSupportedMimeTypeList); ++i) {
     supported_mime_types_.insert(kSupportedMimeTypeList[i]);
   }
 }
 
 GViewRequestInterceptor::~GViewRequestInterceptor() {
 }
 
@@ skipping 22 matching lines @@
   webkit::WebPluginInfo plugin;
   if (!PluginService::GetInstance()->GetPluginInfoByPath(pdf_path, &plugin)) {
     return false;
   }
 
   return ChromePluginServiceFilter::GetInstance()->ShouldUsePlugin(
       info->child_id(), info->route_id(), info->context(),
       request->url(), GURL(), &plugin);
 }
 
+bool GViewRequestInterceptor::ShouldInterceptScheme(
+    const std::string& scheme) const {
+  return scheme == "http";

[zel, 2011/10/19 21:57:49]

there is a constant for chrome scheme already defined somewhere in Chrome code
base, grep for places where scheme() is used. 

[tbarzic, 2011/10/19 23:30:28]

Done.

+}
+
 net::URLRequestJob* GViewRequestInterceptor::MaybeInterceptResponse(
     net::URLRequest* request) const {
   // Do not intercept this request if it is a download.
   if (request->load_flags() & net::LOAD_IS_DOWNLOAD) {
     return NULL;
   }
 
   std::string mime_type;
   request->GetMimeType(&mime_type);
+
+  if (request->method() != "GET" ||
+      !ShouldInterceptScheme(request->original_url().scheme())) {
+    return NULL;
+  }
+
   // If the local PDF viewing plug-in is installed and enabled, don't
   // redirect PDF files to Google Document Viewer.
   if (mime_type == kPdfMimeType && ShouldUsePdfPlugin(request))
     return NULL;
+
   // If supported, build the URL to the Google Document Viewer
   // including the origial document's URL, then create a new job that
   // will redirect the browser to this new URL.
   if (supported_mime_types_.count(mime_type) > 0) {
     std::string url(kGViewUrlPrefix);
     url += EscapePath(request->url().spec());
     return new net::URLRequestRedirectJob(request, GURL(url));
   }
   return NULL;
 }
 
 }  // namespace chromeos