Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 8356042: Switch ChildProcess.* enum histograms from COUNTS to ENUMERATION. (Closed)

Created:
9 years, 2 months ago by petkov
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Switch ChildProcess.* enum histograms from COUNTS to ENUMERATION. These histograms shouldn't have been _COUNTS histograms in the first place. _COUNTS histograms bucket the data in exponentially spaced buckets. This causes, for example, PPAPI crashes to be bucketed together with (and as) GPU crashes. To avoid messing up collected data and to ensure smooth transition, renamed histograms. BUG=chromium-os:21841 TEST=git try, looked at about:histograms Change-Id: I137499992c60bdf6488561150f5b6642acc862b8 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M content/browser/browser_child_process_host.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/common/child_process_info.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
petkov
I'll update the histogram-descriptions XML once this patch goes in. jam: Please review, since you're ...
9 years, 2 months ago (2011-10-20 14:35:54 UTC) #1
jam
lgtm
9 years, 2 months ago (2011-10-20 17:40:17 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
9 years, 2 months ago (2011-10-21 00:47:00 UTC) #3
jar (doing other things)
lgtm
9 years, 2 months ago (2011-10-21 01:50:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petkov@chromium.org/8356042/1
9 years, 2 months ago (2011-10-24 20:07:33 UTC) #5
commit-bot: I haz the power
Try job failure for 8356042-1 on linux_clang for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=11305 Step "update" is always ...
9 years, 2 months ago (2011-10-24 20:09:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petkov@chromium.org/8356042/1
9 years, 2 months ago (2011-10-24 20:55:07 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-24 22:27:02 UTC) #8
Change committed as 106993

Powered by Google App Engine
This is Rietveld 408576698